From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Subject: [PATCH 1/3] ext2fs: initialize handle to NULL in ext2fs_count_blks
Date: Thu, 4 Feb 2021 15:35:59 -0800 [thread overview]
Message-ID: <20210204233601.2369470-1-harshads@google.com> (raw)
From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Initialize the handle to NULL to ensure that in error cases,
ext2fs_free_mem can be called on it.
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
---
lib/ext2fs/extent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ext2fs/extent.c b/lib/ext2fs/extent.c
index bde6b0f3..1a87e68b 100644
--- a/lib/ext2fs/extent.c
+++ b/lib/ext2fs/extent.c
@@ -1809,7 +1809,7 @@ errcode_t ext2fs_decode_extent(struct ext2fs_extent *to, void *addr, int len)
errcode_t ext2fs_count_blocks(ext2_filsys fs, ext2_ino_t ino,
struct ext2_inode *inode, blk64_t *ret_count)
{
- ext2_extent_handle_t handle;
+ ext2_extent_handle_t handle = NULL;
struct ext2fs_extent extent;
errcode_t errcode;
int i;
--
2.30.0.365.g02bc693789-goog
next reply other threads:[~2021-02-04 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 23:35 Harshad Shirwadkar [this message]
2021-02-04 23:36 ` [PATCH 2/3] e2fsck: don't print errcode if the errcode is 0 Harshad Shirwadkar
2021-02-09 4:48 ` Theodore Ts'o
2021-02-04 23:36 ` [PATCH 3/3] e2fsck: endianness fixes for fast commit replay Harshad Shirwadkar
2021-02-09 4:49 ` Theodore Ts'o
2021-02-09 4:47 ` [PATCH 1/3] ext2fs: initialize handle to NULL in ext2fs_count_blks Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204233601.2369470-1-harshads@google.com \
--to=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox