From: riteshh <riteshh@linux.ibm.com>
To: chenyichong <chenyichong@uniontech.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use local variables ei instead of invoking function EXT4_I
Date: Thu, 27 May 2021 08:19:26 +0530 [thread overview]
Message-ID: <20210527024926.oqfxngkm4phgrim4@riteshh-domain> (raw)
In-Reply-To: <20210526052930.11278-1-chenyichong@uniontech.com>
On 21/05/26 01:29PM, chenyichong wrote:
Thanks for the patch. Looks good to me.
Feel free to add
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
> Signed-off-by: chenyichong <chenyichong@uniontech.com>
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index fe6045a46599..a5c4cd1c757b 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -374,7 +374,7 @@ void ext4_da_update_reserve_space(struct inode *inode,
> ei->i_reserved_data_blocks -= used;
> percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
>
> - spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> + spin_unlock(&ei->i_block_reservation_lock);
>
> /* Update quota subsystem for data blocks */
> if (quota_claim)
> --
> 2.20.1
>
>
>
next prev parent reply other threads:[~2021-05-27 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 5:29 [PATCH] use local variables ei instead of invoking function EXT4_I chenyichong
2021-05-27 2:49 ` riteshh [this message]
2021-06-17 20:23 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527024926.oqfxngkm4phgrim4@riteshh-domain \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=chenyichong@uniontech.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox