linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Yi <yi.zhang@huawei.com>
To: <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <adilger.kernel@dilger.ca>, <jack@suse.cz>,
	<yi.zhang@huawei.com>, <yukuai3@huawei.com>
Subject: [RFC PATCH v3 0/8] ext4, jbd2: fix 3 issues about bdev_try_to_free_page()
Date: Thu, 27 May 2021 21:56:33 +0800	[thread overview]
Message-ID: <20210527135641.420514-1-yi.zhang@huawei.com> (raw)

Patch 1-3: fix a potential filesystem inconsistency problem.
Patch 4-8: add a shrinker to release journal_head and remove
           bdev_try_to_free_page() callback, and also do some cleanup.

Changes since v2:
 - Fix some comments and spelling mistakes on patch 2 and 3.
 - Give up the solution of add refcount on super_block and fix the
   use-after-free issue in bdev_try_to_free_page(), switch to introduce
   a shrinker to free checkpoint buffers' journal_head and remove the
   whole callback at all.

Thanks,
Yi.

---------

Changes since v1:
 - Do not use j_checkpoint_mutex to fix the filesystem inconsistency
   problem, introduce a new mark instead.
 - Fix superblock use-after-free issue in blkdev_releasepage().
 - Avoid race between bdev_try_to_free_page() and ext4_put_super().



Zhang Yi (8):
  jbd2: remove the out label in __jbd2_journal_remove_checkpoint()
  jbd2: ensure abort the journal if detect IO error when writing
    original buffer back
  jbd2: don't abort the journal when freeing buffers
  jbd2: remove redundant buffer io error checks
  jbd2,ext4: add a shrinker to release checkpointed buffers
  jbd2: simplify journal_clean_one_cp_list()
  ext4: remove bdev_try_to_free_page() callback
  fs: remove bdev_try_to_free_page callback

 fs/block_dev.c              |  15 ---
 fs/ext4/super.c             |  29 ++----
 fs/jbd2/checkpoint.c        | 200 ++++++++++++++++++++++++++++++------
 fs/jbd2/journal.c           | 101 ++++++++++++++++++
 fs/jbd2/transaction.c       |  17 ---
 include/linux/fs.h          |   1 -
 include/linux/jbd2.h        |  37 +++++++
 include/trace/events/jbd2.h | 101 ++++++++++++++++++
 8 files changed, 413 insertions(+), 88 deletions(-)

-- 
2.25.4


             reply	other threads:[~2021-05-27 13:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 13:56 Zhang Yi [this message]
2021-05-27 13:56 ` [RFC PATCH v3 1/8] jbd2: remove the out label in __jbd2_journal_remove_checkpoint() Zhang Yi
2021-05-27 13:56 ` [RFC PATCH v3 2/8] jbd2: ensure abort the journal if detect IO error when writing original buffer back Zhang Yi
2021-06-03 16:21   ` Jan Kara
2021-05-27 13:56 ` [RFC PATCH v3 3/8] jbd2: don't abort the journal when freeing buffers Zhang Yi
2021-05-27 13:56 ` [RFC PATCH v3 4/8] jbd2: remove redundant buffer io error checks Zhang Yi
2021-06-03 16:28   ` Jan Kara
2021-06-10  2:05     ` Zhang Yi
2021-05-27 13:56 ` [RFC PATCH v3 5/8] jbd2,ext4: add a shrinker to release checkpointed buffers Zhang Yi
2021-06-07 15:45   ` Jan Kara
2021-06-09  3:00   ` Dave Chinner
2021-06-10  2:38     ` Zhang Yi
2021-05-27 13:56 ` [RFC PATCH v3 6/8] jbd2: simplify journal_clean_one_cp_list() Zhang Yi
2021-06-07 15:50   ` Jan Kara
2021-05-27 13:56 ` [RFC PATCH v3 7/8] ext4: remove bdev_try_to_free_page() callback Zhang Yi
2021-06-07 15:50   ` Jan Kara
2021-05-27 13:56 ` [RFC PATCH v3 8/8] fs: remove bdev_try_to_free_page callback Zhang Yi
2021-06-07 15:50   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527135641.420514-1-yi.zhang@huawei.com \
    --to=yi.zhang@huawei.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).