From: yangerkun <yangerkun@huawei.com>
To: <tytso@mit.edu>, <jack@suse.com>, <harshadshirwadkar@gmail.com>
Cc: <linux-ext4@vger.kernel.org>, <yangerkun@huawei.com>,
<yukuai3@huawei.com>
Subject: [PATCH] jbd2: clean up misleading comments for jbd2_fc_release_bufs
Date: Tue, 8 Jun 2021 22:12:36 +0800 [thread overview]
Message-ID: <20210608141236.459441-1-yangerkun@huawei.com> (raw)
This comments was for jbd2_fc_wait_bufs, not for jbd2_fc_release_bufs.
Remove this misleading comments.
Signed-off-by: yangerkun <yangerkun@huawei.com>
---
fs/jbd2/journal.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 2dc944442802..ea46e5ad6b59 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -934,10 +934,6 @@ int jbd2_fc_wait_bufs(journal_t *journal, int num_blks)
}
EXPORT_SYMBOL(jbd2_fc_wait_bufs);
-/*
- * Wait on fast commit buffers that were allocated by jbd2_fc_get_buf
- * for completion.
- */
int jbd2_fc_release_bufs(journal_t *journal)
{
struct buffer_head *bh;
@@ -945,10 +941,6 @@ int jbd2_fc_release_bufs(journal_t *journal)
j_fc_off = journal->j_fc_off;
- /*
- * Wait in reverse order to minimize chances of us being woken up before
- * all IOs have completed
- */
for (i = j_fc_off - 1; i >= 0; i--) {
bh = journal->j_fc_wbuf[i];
if (!bh)
--
2.31.1
next reply other threads:[~2021-06-08 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 14:12 yangerkun [this message]
2021-06-09 8:56 ` [PATCH] jbd2: clean up misleading comments for jbd2_fc_release_bufs Jan Kara
2021-06-24 14:27 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608141236.459441-1-yangerkun@huawei.com \
--to=yangerkun@huawei.com \
--cc=harshadshirwadkar@gmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox