From: "Darrick J. Wong" <djwong@kernel.org>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/9] ext4/027: Correct the right code of block and inode bitmap
Date: Mon, 14 Jun 2021 09:40:56 -0700 [thread overview]
Message-ID: <20210614164056.GA2945720@locust> (raw)
In-Reply-To: <cf9babe1f24507d31886d806053dd1b93f2d144b.1623651783.git.riteshh@linux.ibm.com>
On Mon, Jun 14, 2021 at 11:58:06AM +0530, Ritesh Harjani wrote:
> Observed occasional failure of this test sometimes say with 64k config
> and small device size. Reason is we were grepping for wrong values for
> inode and block bitmap.
>
> Correct those values according to [1] to fix this test.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/fsmap.h#n53
>
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
> ---
> tests/ext4/027 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/ext4/027 b/tests/ext4/027
> index 97c14cf5..83d5a413 100755
> --- a/tests/ext4/027
> +++ b/tests/ext4/027
> @@ -45,11 +45,11 @@ x=$(grep -c 'static fs metadata' $TEST_DIR/fsmap)
> test $x -gt 0 || echo "No fs metadata?"
>
> echo "Check block bitmap" | tee -a $seqres.full
> -x=$(grep -c 'special 102:1' $TEST_DIR/fsmap)
> +x=$(grep -c 'special 102:3' $TEST_DIR/fsmap)
> test $x -gt 0 || echo "No block bitmaps?"
>
> echo "Check inode bitmap" | tee -a $seqres.full
> -x=$(grep -c 'special 102:2' $TEST_DIR/fsmap)
> +x=$(grep -c 'special 102:4' $TEST_DIR/fsmap)
Maaaaybe I should have added textual descriptions for the ext4 getfsmap
owners. Sorry... :(
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> test $x -gt 0 || echo "No inode bitmaps?"
>
> echo "Check inodes" | tee -a $seqres.full
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-06-14 16:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 6:28 [PATCH 0/9] 64K blocksize related fixes Ritesh Harjani
2021-06-14 6:28 ` [PATCH 1/9] ext4/003: Fix this test on 64K platform for dax config Ritesh Harjani
2021-06-30 16:27 ` Theodore Ts'o
2021-07-08 6:24 ` Ritesh Harjani
2021-07-08 12:51 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 2/9] ext4/027: Correct the right code of block and inode bitmap Ritesh Harjani
2021-06-14 16:40 ` Darrick J. Wong [this message]
2021-06-14 6:28 ` [PATCH 3/9] ext4/306: Add -b blocksize parameter too to avoid failure with DAX config Ritesh Harjani
2021-06-30 16:29 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 4/9] ext4/022: exclude this test for dax config on 64KB pagesize platform Ritesh Harjani
2021-06-30 16:36 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 5/9] generic/031: Fix the test case for 64k blocksize config Ritesh Harjani
2021-06-30 15:50 ` Darrick J. Wong
2021-06-30 17:18 ` Theodore Ts'o
2021-07-08 9:49 ` Ritesh Harjani
2021-06-14 6:28 ` [PATCH 6/9] gitignore: Add 031.out file to .gitignore Ritesh Harjani
2021-06-30 16:36 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 7/9] generic/620: Remove -b blocksize option for ext4 Ritesh Harjani
2021-06-30 17:07 ` Theodore Ts'o
2021-07-08 10:01 ` Ritesh Harjani
2021-06-14 6:28 ` [PATCH 8/9] common/attr: Cleanup end of line whitespaces issues Ritesh Harjani
2021-06-30 15:50 ` Darrick J. Wong
2021-06-30 17:19 ` Theodore Ts'o
2021-06-14 6:28 ` [PATCH 9/9] common/attr: Reduce MAX_ATTRS to leave some overhead for 64K blocksize Ritesh Harjani
2021-06-30 15:51 ` Darrick J. Wong
2021-06-30 19:20 ` Theodore Ts'o
2021-07-09 5:12 ` Ritesh Harjani
2021-06-30 13:30 ` [PATCH 0/9] 64K blocksize related fixes Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614164056.GA2945720@locust \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).