linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ext4: remove conflict comment from __ext4_forget
@ 2021-07-14  5:59 Guoqing Jiang
  2021-07-23 11:33 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Guoqing Jiang @ 2021-07-14  5:59 UTC (permalink / raw)
  To: tytso, adilger.kernel; +Cc: linux-ext4

From: Guoqing Jiang <jiangguoqing@kylinos.cn>

We do a bforget and return for no journal case, so let's remove this
conflict comment.

Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
---
Change from RFC: add Jan's Reviewed-by.

 fs/ext4/ext4_jbd2.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c
index be799040a415..6e224b19eae7 100644
--- a/fs/ext4/ext4_jbd2.c
+++ b/fs/ext4/ext4_jbd2.c
@@ -244,9 +244,6 @@ int __ext4_journal_get_write_access(const char *where, unsigned int line,
  * "bh" may be NULL: a metadata block may have been freed from memory
  * but there may still be a record of it in the journal, and that record
  * still needs to be revoked.
- *
- * If the handle isn't valid we're not journaling, but we still need to
- * call into ext4_journal_revoke() to put the buffer head.
  */
 int __ext4_forget(const char *where, unsigned int line, handle_t *handle,
 		  int is_metadata, struct inode *inode,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ext4: remove conflict comment from __ext4_forget
  2021-07-14  5:59 [PATCH] ext4: remove conflict comment from __ext4_forget Guoqing Jiang
@ 2021-07-23 11:33 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2021-07-23 11:33 UTC (permalink / raw)
  To: Guoqing Jiang; +Cc: adilger.kernel, linux-ext4

On Wed, Jul 14, 2021 at 01:59:40PM +0800, Guoqing Jiang wrote:
> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
> 
> We do a bforget and return for no journal case, so let's remove this
> conflict comment.
> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>

Thanks, applied.

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-23 11:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-14  5:59 [PATCH] ext4: remove conflict comment from __ext4_forget Guoqing Jiang
2021-07-23 11:33 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).