From: Christoph Hellwig <hch@lst.de>
To: Mikulas Patocka <mikulas@twibright.com>
Cc: Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.com>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: remove generic_block_fiemap
Date: Wed, 21 Jul 2021 07:37:17 +0200 [thread overview]
Message-ID: <20210721053717.GA8625@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2107201857100.27763@leontynka>
On Tue, Jul 20, 2021 at 07:02:10PM +0200, Mikulas Patocka wrote:
> You can download a test HPFS partition here:
> http://artax.karlin.mff.cuni.cz/~mikulas/vyplody/hpfs/test-hpfs-partition.gz
looks like xfstests doesn't generally work on hpfs, and even if I tried
i would be rather slow due to the lack of sparse files.
So I tested fiemp against a few simple copied over files and it still
works.
There are some cases where the old code reported contiguous ranges
as two extents while the new one doesn't, for rasons that are not
quite clear to me:
--- fiemap.old 2021-07-21 05:00:29.000000000 +0000
+++ fiemap.iomap 2021-07-21 04:57:20.000000000 +0000
@@ -1,3 +1,2 @@
dmesg:
- 0: [0..66]: 133817..133883
- 1: [67..67]: 133884..133884
+ 0: [0..67]: 133817..133884
prev parent reply other threads:[~2021-07-21 5:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 13:33 remove generic_block_fiemap Christoph Hellwig
2021-07-20 13:33 ` [PATCH 1/4] ext2: make ext2_iomap_ops available unconditionally Christoph Hellwig
2021-07-26 13:33 ` Jan Kara
2021-07-20 13:33 ` [PATCH 2/4] ext2: use iomap_fiemap to implement ->fiemap Christoph Hellwig
2021-07-26 13:41 ` Jan Kara
2021-07-20 13:33 ` [PATCH 3/4] hpfs: " Christoph Hellwig
2021-07-20 13:33 ` [PATCH 4/4] fs: remove generic_block_fiemap Christoph Hellwig
2021-07-26 13:52 ` Jan Kara
2021-07-26 13:54 ` Christoph Hellwig
2021-07-26 16:17 ` Jan Kara
2021-07-20 17:02 ` Mikulas Patocka
2021-07-21 5:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721053717.GA8625@lst.de \
--to=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=mikulas@twibright.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).