From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF38C4338F for ; Wed, 11 Aug 2021 17:33:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE70860E97 for ; Wed, 11 Aug 2021 17:33:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230394AbhHKReJ (ORCPT ); Wed, 11 Aug 2021 13:34:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52660 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbhHKReI (ORCPT ); Wed, 11 Aug 2021 13:34:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628703224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sn996wyP1762RVthxVYilsh2trpZDoQDtSXbn8LQEl0=; b=HXUPMi8Sqm3mbvbkeA/BOdhv1uilXxM6FviNXZRXlqXN8uJcUTw7ptwfyfecv5+KvJ/7Kp qb71/zGK5ZV5so/jDHLUXbVRrLtpiPatAL2ss+lLxyrUOg9fr5hQA2U+LDPXX+UDUaYtrx ievQpB9lpQ3erJxzfbsa/ONi5HgW5aM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-EUH6_ZzyNqW1tLQO1_bJuQ-1; Wed, 11 Aug 2021 13:33:43 -0400 X-MC-Unique: EUH6_ZzyNqW1tLQO1_bJuQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 669BF824F8C; Wed, 11 Aug 2021 17:33:42 +0000 (UTC) Received: from work (unknown [10.40.192.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90E92781E7; Wed, 11 Aug 2021 17:33:41 +0000 (UTC) Date: Wed, 11 Aug 2021 19:33:38 +0200 From: Lukas Czerner To: Theodore Ts'o Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/7] e2fsck: value stored to err is never read Message-ID: <20210811173338.ikxkrprvdo345zef@work> References: <20210806095820.83731-1-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Aug 10, 2021 at 10:58:56AM -0400, Theodore Ts'o wrote: > On Fri, Aug 06, 2021 at 11:58:14AM +0200, Lukas Czerner wrote: > > Remove it to silence clang warning. > > > > Signed-off-by: Lukas Czerner > > Applied, thanks. > > Note that we try to keep e2fsck/recovery.c and fs/jbd2/recovery.c in > sync, so it's appreciated patches sent to e2fsck/recovery.c or > fs/jbd2/recovery.c is sent to the other. I can take care of it in > this case. > > Cheers, > > - Ted Allright, I'll keep that in mind for the next time. Thanks! -Lukas