From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C910C4320E for ; Wed, 18 Aug 2021 14:26:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83D9E60041 for ; Wed, 18 Aug 2021 14:26:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239177AbhHRO0m (ORCPT ); Wed, 18 Aug 2021 10:26:42 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:52062 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239090AbhHRO0j (ORCPT ); Wed, 18 Aug 2021 10:26:39 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 2F68722076; Wed, 18 Aug 2021 14:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1629296762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Zbc/uB0zhyDd1UPDQj6ABNQkkgL7DcrMjSWW5vnxtk=; b=RxF8JdkjGfP9OiQj1DGhegz5q4Sm8uyLDO8wToc8vu2+8LyHuXpjjyR9NcczFLEgqG3v2b 15GL6EpmR6qLvH9t+qJ3oW/poW5GIAih3xZj2p+a8VI1z9ISEoR1H4+GEcmWvrvzW79Vcz eqS8MT2Wb4k6vCCIy24K7ejWTfDF+hw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1629296762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Zbc/uB0zhyDd1UPDQj6ABNQkkgL7DcrMjSWW5vnxtk=; b=K2yQrMVx4qUE+w3gA08gpsciZ817nM62gsdu6pelt+b43S+pu9i69CH/dIyASlYbu63C7j y09MY0xF5Le0kNAA== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id 23109A3B96; Wed, 18 Aug 2021 14:26:02 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id E94461E14B9; Wed, 18 Aug 2021 16:26:01 +0200 (CEST) Date: Wed, 18 Aug 2021 16:26:01 +0200 From: Jan Kara To: Boyang Xue Cc: fstests@vger.kernel.org, Jan Kara , linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: regression test for "tune2fs -l" after ext4 shutdown Message-ID: <20210818142601.GF28119@quack2.suse.cz> References: <20210818084126.4167799-1-bxue@redhat.com> <20210818114517.kqvfzu2vd45vuhze@fedora> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed 18-08-21 21:20:44, Boyang Xue wrote: > > > + > > > +# real QA test starts here > > > +_supported_fs ext4 > > > > I'm wondering if this case can be a generic case, there's nothing > > ext4 specified operations, except this line: > > > > "$TUNE2FS_PROG -l $SCRATCH_DEV" > > > > Hmm... if we can change this line to something likes _get_fs_super(), > > it might help to make this test to be a generic test. > > I think this bug is heavily related to "tune2fs", ext4 only. So I > guess an ext4 only test is enough? FWIW I agree with Boyang here. For this test to make sense for any other filesystem other the filesystem would need to read fs metadata through buffer cache in _get_fs_super(). Furthermore it is somewhat ext2/3/4 specific (due to historical reasons) that reading superblock from the buffer cache of a mounted filesystem is expected to result in something sensible. Usually this is plain unsupported use... Honza -- Jan Kara SUSE Labs, CR