From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-ext4-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C83EBC4338F
	for <linux-ext4@archiver.kernel.org>; Wed, 18 Aug 2021 14:58:17 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id B0523610CB
	for <linux-ext4@archiver.kernel.org>; Wed, 18 Aug 2021 14:58:17 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S239584AbhHRO6v (ORCPT <rfc822;linux-ext4@archiver.kernel.org>);
        Wed, 18 Aug 2021 10:58:51 -0400
Received: from verein.lst.de ([213.95.11.211]:34226 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S238483AbhHRO6v (ORCPT <rfc822;linux-ext4@vger.kernel.org>);
        Wed, 18 Aug 2021 10:58:51 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 1787E67373; Wed, 18 Aug 2021 16:58:14 +0200 (CEST)
Date:   Wed, 18 Aug 2021 16:58:13 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Christoph Hellwig <hch@lst.de>,
        Gabriel Krisman Bertazi <krisman@collabora.com>,
        Shreeya Patel <shreeya.patel@collabora.com>,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 11/11] unicode: only export internal symbols for the
 selftests
Message-ID: <20210818145813.GA13343@lst.de>
References: <20210818140651.17181-1-hch@lst.de> <20210818140651.17181-12-hch@lst.de> <YR0fuyqe7NS+mCf9@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YR0fuyqe7NS+mCf9@casper.infradead.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Wed, Aug 18, 2021 at 03:56:59PM +0100, Matthew Wilcox wrote:
> On Wed, Aug 18, 2021 at 04:06:51PM +0200, Christoph Hellwig wrote:
> > The exported symbols in utf8-norm.c are not needed for normal
> > file system consumers, so move them to conditional _GPL exports
> > just for the selftest.
> 
> Would it be better to use EXPORT_SYMBOL_NS_GPL()?

Maybe.  Even better would be the EXPORT_SYMBOL_FOR I've been prototyping
for a while but which is still not ready.