From: Ye Bin <yebin10@huawei.com>
To: <tytso@mit.edu>, <adilger.kernel@dilger.ca>,
<linux-ext4@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <jack@suse.cz>,
Ye Bin <yebin10@huawei.com>
Subject: [PATCH -next v2 5/6] ext4: avoid to double free s_mmp_bh
Date: Sat, 11 Sep 2021 17:00:58 +0800 [thread overview]
Message-ID: <20210911090059.1876456-6-yebin10@huawei.com> (raw)
In-Reply-To: <20210911090059.1876456-1-yebin10@huawei.com>
If call read_mmp_block failed then s_mmp_bh will be freed in read_mmp_block.
Kmmpd wait to be killed, ext4_stop_mmpd stop kmmpd and also release s_mmp_bh.
To avoid double free, just set EXT4_SB(sb)->s_mmp_bh with NULL.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
fs/ext4/mmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 007bde3c12b8..a0d47a906faa 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -218,6 +218,7 @@ static int kmmpd(void *data)
ext4_error_err(sb, -retval,
"error reading MMP data: %d",
retval);
+ EXT4_SB(sb)->s_mmp_bh = NULL;
goto wait_to_exit;
}
--
2.31.1
next prev parent reply other threads:[~2021-09-11 8:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 9:00 [PATCH -next v2 0/6] Fix some issues about mmp Ye Bin
2021-09-11 9:00 ` [PATCH -next v2 1/6] ext4: init seq with random value in kmmpd Ye Bin
2021-10-07 12:26 ` Jan Kara
2021-10-08 1:50 ` yebin
2021-09-11 9:00 ` [PATCH -next v2 2/6] ext4: introduce last_check_time record previous check time Ye Bin
2021-10-07 12:31 ` Jan Kara
2021-10-08 1:56 ` yebin
2021-10-08 2:38 ` yebin
2021-10-12 8:47 ` Jan Kara
2021-10-12 11:46 ` yebin
2021-10-13 9:38 ` Jan Kara
2021-10-13 12:33 ` yebin
2021-10-13 21:41 ` Theodore Ts'o
2021-10-15 3:21 ` Andreas Dilger
2021-10-15 3:21 ` Andreas Dilger
2021-09-11 9:00 ` [PATCH -next v2 3/6] ext4: compare to local seq and nodename when check conflict Ye Bin
2021-10-07 12:36 ` Jan Kara
2021-09-11 9:00 ` [PATCH -next v2 4/6] ext4: avoid to re-read mmp check data get from page cache Ye Bin
2021-10-07 12:44 ` Jan Kara
2021-10-08 3:52 ` yebin
2021-09-11 9:00 ` Ye Bin [this message]
2021-09-11 9:00 ` [PATCH -next v2 6/6] ext4: fix possible store wrong check interval value in disk when umount Ye Bin
2021-10-07 13:12 ` Jan Kara
2021-10-08 3:49 ` yebin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210911090059.1876456-6-yebin10@huawei.com \
--to=yebin10@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).