public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Whitney <enwlinux@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eric Whitney <enwlinux@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Revert "ext4: enforce buffer head state assertion in ext4_da_map_blocks"
Date: Wed, 3 Nov 2021 15:14:57 -0400	[thread overview]
Message-ID: <20211103191457.GA3838@localhost.localdomain> (raw)
In-Reply-To: <163415796177.214938.9752602885736039327.b4-ty@mit.edu>

* Theodore Ts'o <tytso@mit.edu>:
> On Tue, 12 Oct 2021 13:19:01 -0400, Eric Whitney wrote:
> > This reverts commit 948ca5f30e1df0c11eb5b0f410b9ceb97fa77ad9.
> > 
> > Two crash reports from users running variations on 5.15-rc4 kernels
> > suggest that it is premature to enforce the state assertion in the
> > original commit.  Both crashes were triggered by BUG calls in that
> > code, indicating that under some rare circumstance the buffer head
> > state did not match a delayed allocated block at the time the
> > block was written out.  No reproducer is available.  Resolving this
> > problem will require more time than remains in the current release
> > cycle, so reverting the original patch for the time being is necessary
> > to avoid any instability it may cause.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] Revert "ext4: enforce buffer head state assertion in ext4_da_map_blocks"
>       commit: 52264b162a51eadb0adcb55297cf91905c6ede98
> 
> Best regards,
> -- 
> Theodore Ts'o <tytso@mit.edu>

Hi Ted:

This reversion isn't visible in the 5.15 kernel.  We'll want to get this in as
a bug fix to 5.15.1 if possible.  Please let me know if there's anything I can
do to expedite.

Thanks,
Eric


  reply	other threads:[~2021-11-03 19:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 17:19 [PATCH] Revert "ext4: enforce buffer head state assertion in ext4_da_map_blocks" Eric Whitney
2021-10-13 20:46 ` Theodore Ts'o
2021-11-03 19:14   ` Eric Whitney [this message]
2021-11-04 14:36     ` Theodore Ts'o
2021-10-26  9:52 ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103191457.GA3838@localhost.localdomain \
    --to=enwlinux@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox