From: Dan Carpenter <dan.carpenter@oracle.com>
To: harshadshirwadkar@gmail.com
Cc: linux-ext4@vger.kernel.org
Subject: [bug report] ext4: fast commit recovery path
Date: Tue, 30 Nov 2021 12:40:06 +0300 [thread overview]
Message-ID: <20211130094006.GA29296@kili> (raw)
Hello Harshad Shirwadkar,
The patch 8016e29f4362: "ext4: fast commit recovery path" from Oct
15, 2020, leads to the following Smatch static checker warnings:
fs/ext4/inode.c:4533 __ext4_get_inode_loc_noinmem()
error: uninitialized symbol 'err_blk'.
fs/ext4/inode.c:4548 ext4_get_inode_loc()
error: uninitialized symbol 'err_blk'.
fs/ext4/inode.c
4523 static int __ext4_get_inode_loc_noinmem(struct inode *inode,
4524 struct ext4_iloc *iloc)
4525 {
4526 ext4_fsblk_t err_blk;
4527 int ret;
4528
4529 ret = __ext4_get_inode_loc(inode->i_sb, inode->i_ino, NULL, iloc,
4530 &err_blk);
4531
4532 if (ret == -EIO)
--> 4533 ext4_error_inode_block(inode, err_blk, EIO,
Only the last return -EIO sets err_blk. The first return -EIO leaves it
uninitialized.
4534 "unable to read itable block");
4535
4536 return ret;
4537 }
regards,
dan carpenter
next reply other threads:[~2021-11-30 9:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 9:40 Dan Carpenter [this message]
2021-12-01 16:35 ` [bug report] ext4: fast commit recovery path harshad shirwadkar
-- strict thread matches above, loose matches on Subject: below --
2020-10-27 8:09 Dan Carpenter
2020-10-27 18:00 ` harshad shirwadkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130094006.GA29296@kili \
--to=dan.carpenter@oracle.com \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox