From: "Luís Henriques" <lhenriques@suse.de>
To: Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
"Luís Henriques" <lhenriques@suse.de>,
"Jeroen van Wolffelaar" <jeroen@wolffelaar.nl>
Subject: [PATCH] ext4: set csum seed in tmp inode while migrating to extents
Date: Mon, 6 Dec 2021 14:37:33 +0000 [thread overview]
Message-ID: <20211206143733.18918-1-lhenriques@suse.de> (raw)
In-Reply-To: <bug-213357-13602@https.bugzilla.kernel.org>
When migrating to extents, the temporary inode will have it's own checksum
seed. This means that, when swapping the inodes data, the inode checksums
will be incorrect.
This can be fixed by recalculating the extents checksums again. Or simply
by copying the seed into the temporary inode.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=213357
Reported-by: Jeroen van Wolffelaar <jeroen@wolffelaar.nl>
Signed-off-by: Luís Henriques <lhenriques@suse.de>
---
fs/ext4/migrate.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
index 7e0b4f81c6c0..dd4ece38fc83 100644
--- a/fs/ext4/migrate.c
+++ b/fs/ext4/migrate.c
@@ -413,7 +413,7 @@ int ext4_ext_migrate(struct inode *inode)
handle_t *handle;
int retval = 0, i;
__le32 *i_data;
- struct ext4_inode_info *ei;
+ struct ext4_inode_info *ei, *tmp_ei;
struct inode *tmp_inode = NULL;
struct migrate_struct lb;
unsigned long max_entries;
@@ -503,6 +503,10 @@ int ext4_ext_migrate(struct inode *inode)
}
ei = EXT4_I(inode);
+ tmp_ei = EXT4_I(tmp_inode);
+ /* Use the right seed for checksumming */
+ tmp_ei->i_csum_seed = ei->i_csum_seed;
+
i_data = ei->i_data;
memset(&lb, 0, sizeof(lb));
next parent reply other threads:[~2021-12-06 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-213357-13602@https.bugzilla.kernel.org>
2021-12-06 14:37 ` Luís Henriques [this message]
2021-12-14 12:03 ` [PATCH] ext4: set csum seed in tmp inode while migrating to extents Jan Kara
2021-12-14 16:46 ` Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206143733.18918-1-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=adilger.kernel@dilger.ca \
--cc=jeroen@wolffelaar.nl \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox