From: Jan Kara <jack@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org
Subject: Re: [bug report] ext4: Set flags on quota files directly
Date: Wed, 15 Dec 2021 12:59:27 +0100 [thread overview]
Message-ID: <20211215115927.GN14044@quack2.suse.cz> (raw)
In-Reply-To: <20211215114231.GA12626@kili>
Hello Dan!
On Wed 15-12-21 14:42:31, Dan Carpenter wrote:
> The patch 957153fce8d2: "ext4: Set flags on quota files directly"
> from Apr 6, 2017, leads to the following Smatch static checker
> warning:
>
> fs/ext4/super.c:6779 ext4_quota_on()
> warn: missing error code here? 'IS_ERR()' failed. 'err' = '0'
>
> fs/ext4/super.c
> 6761
> 6762 lockdep_set_quota_inode(path->dentry->d_inode, I_DATA_SEM_QUOTA);
> 6763 err = dquot_quota_on(sb, type, format_id, path);
> 6764 if (err) {
> 6765 lockdep_set_quota_inode(path->dentry->d_inode,
> 6766 I_DATA_SEM_NORMAL);
> 6767 } else {
> 6768 struct inode *inode = d_inode(path->dentry);
> 6769 handle_t *handle;
> 6770
> 6771 /*
> 6772 * Set inode flags to prevent userspace from messing with quota
> 6773 * files. If this fails, we return success anyway since quotas
> 6774 * are already enabled and this is not a hard failure.
> 6775 */
> 6776 inode_lock(inode);
> 6777 handle = ext4_journal_start(inode, EXT4_HT_QUOTA, 1);
> 6778 if (IS_ERR(handle))
> --> 6779 goto unlock_inode;
>
> This should set "err = PTR_ERR(handle)" right?
The comment above explains it I guess. We don't want to return error if
ext4_journal_start() fails because it is a "soft" failure we can absorb.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-12-15 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 11:42 [bug report] ext4: Set flags on quota files directly Dan Carpenter
2021-12-15 11:59 ` Jan Kara [this message]
2021-12-15 12:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215115927.GN14044@quack2.suse.cz \
--to=jack@suse.cz \
--cc=dan.carpenter@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).