From: Lukas Czerner <lczerner@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Carlos Maiolino <cmaiolino@redhat.com>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext4: fix a copy and paste typo
Date: Wed, 15 Dec 2021 13:10:33 +0100 [thread overview]
Message-ID: <20211215121033.nclqc5b7qnterwek@work> (raw)
In-Reply-To: <20211215114309.GB14552@kili>
On Wed, Dec 15, 2021 at 02:43:09PM +0300, Dan Carpenter wrote:
> This was obviously supposed to be an ext4 struct, not xfs. GCC
> doesn't care either way so it doesn't affect the build or runtime.
Wow, what a mistake. Nice catch, thanks!
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
>
> Fixes: cebe85d570cf ("ext4: switch to the new mount api")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 5ec5a1c3b364..da40fb468d7f 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2077,7 +2077,7 @@ static void ext4_fc_free(struct fs_context *fc)
>
> int ext4_init_fs_context(struct fs_context *fc)
> {
> - struct xfs_fs_context *ctx;
> + struct ext4_fs_context *ctx;
>
> ctx = kzalloc(sizeof(struct ext4_fs_context), GFP_KERNEL);
> if (!ctx)
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-12-15 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 11:43 [PATCH] ext4: fix a copy and paste typo Dan Carpenter
2021-12-15 12:10 ` Lukas Czerner [this message]
2022-01-06 4:41 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215121033.nclqc5b7qnterwek@work \
--to=lczerner@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=cmaiolino@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox