From: Lukas Czerner <lczerner@redhat.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Problem with data=ordered ext4 mount option in linux-next
Date: Fri, 17 Dec 2021 16:24:56 +0100 [thread overview]
Message-ID: <20211217152456.l7b2mbefdkk64fkj@work> (raw)
In-Reply-To: <b5817114-8122-cf0e-ca8e-b5d1c9f43bc2@gmail.com>
On Fri, Dec 17, 2021 at 04:11:32PM +0100, Heiner Kallweit wrote:
> On linux-next systemd-remount-fs complains about an invalid mount option
> here, resulting in a r/o root fs. After playing with the mount options
> it turned out that data=ordered causes the problem. linux-next from Dec
> 1st was ok, so it seems to be related to the new mount API patches.
>
> At a first glance I saw no obvious problem, the following looks good.
> Maybe you have an idea where to look ..
>
> static const struct constant_table ext4_param_data[] = {
> {"journal", EXT4_MOUNT_JOURNAL_DATA},
> {"ordered", EXT4_MOUNT_ORDERED_DATA},
> {"writeback", EXT4_MOUNT_WRITEBACK_DATA},
> {}
> };
>
> fsparam_enum ("data", Opt_data, ext4_param_data),
>
Thank you for the report!
The ext4 mount has been reworked to use the new mount api and the work
has been applied to linux-next couple of days ago so I definitelly
assume there is a bug in there that I've missed. I will be looking into
it.
Can you be a little bit more specific about how to reproduce the problem
as well as the error it generates in the logs ? Any other mount options
used simultaneously, non-default file system features, or mount options
stored within the superblock ?
Can you reproduce it outside of the systemd unit, say a script ?
Thanks!
-Lukas
next prev parent reply other threads:[~2021-12-17 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:11 Problem with data=ordered ext4 mount option in linux-next Heiner Kallweit
2021-12-17 15:24 ` Lukas Czerner [this message]
2021-12-17 15:34 ` Heiner Kallweit
2021-12-17 17:02 ` Heiner Kallweit
2021-12-17 18:26 ` Heiner Kallweit
2021-12-20 11:12 ` Lukas Czerner
2021-12-25 20:11 ` Sedat Dilek
2021-12-26 20:01 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217152456.l7b2mbefdkk64fkj@work \
--to=lczerner@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox