linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: yinxin.x@bytedance.com, enwlinux@gmail.com,
	Harshad Shirwadkar <harshads@google.com>,
	Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Subject: [PATCH 0/3] ext4 fast commit API cleanup
Date: Sun, 19 Dec 2021 19:17:01 -0800	[thread overview]
Message-ID: <20211220031704.441727-1-harshads@google.com> (raw)

ext4: fast commit API cleanup

This patch series fixes up fast commit APIs. There are NO on-disk
format changes introduced in this series. The main contribution of the
series is that it drops fast commit specific transaction APIs and
makes fast commits work with journal transaction APIs of JBD2
journalling system. With these changes, a fast commit eligible
transaction is simply enclosed in calls to "jbd2_journal_start()" and
"jbd2_journal_stop()". If the update that is being performed is fast
commit ineligible, one must simply call ext4_fc_mark_ineligible()
after starting a transaction using "jbd2_journal_start()". The last
patch in the series simplifies fast commit stats recording by moving
it to a different function.

I verified that the patch series introduces no regressions in "quick"
and "log" groups when "fast_commit" feature is enabled.

Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

Harshad Shirwadkar (3):
  ext4: drop transaction start stop APIs for fast commit
  ext4: drop ineligible txn start stop APIs
  ext4: simplify updating of fast commit stats

 fs/ext4/acl.c         |   2 -
 fs/ext4/ext4.h        |  12 +-
 fs/ext4/extents.c     |   9 +-
 fs/ext4/fast_commit.c | 250 ++++++++++++------------------------------
 fs/ext4/fast_commit.h |  27 ++---
 fs/ext4/file.c        |   4 -
 fs/ext4/inode.c       |   7 +-
 fs/ext4/ioctl.c       |  13 +--
 fs/ext4/super.c       |   1 -
 fs/jbd2/journal.c     |   2 +
 10 files changed, 96 insertions(+), 231 deletions(-)

-- 
2.34.1.173.g76aa8bc2d0-goog


             reply	other threads:[~2021-12-20  3:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20  3:17 Harshad Shirwadkar [this message]
2021-12-20  3:17 ` [PATCH 1/3] ext4: drop transaction start stop APIs for fast commit Harshad Shirwadkar
2021-12-20  3:17 ` [PATCH 2/3] ext4: drop ineligible txn start stop APIs Harshad Shirwadkar
2021-12-20  3:17 ` [PATCH 3/3] ext4: simplify updating of fast commit stats Harshad Shirwadkar
2021-12-22 16:28 ` [PATCH 0/3] ext4 fast commit API cleanup Eric Whitney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211220031704.441727-1-harshads@google.com \
    --to=harshadshirwadkar@gmail.com \
    --cc=enwlinux@gmail.com \
    --cc=harshads@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=yinxin.x@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).