From: Xin Yin <yinxin.x@bytedance.com>
To: harshadshirwadkar@gmail.com, tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Xin Yin <yinxin.x@bytedance.com>
Subject: [PATCH 0/2] ext4: fast commit crash consistency issues
Date: Thu, 23 Dec 2021 11:23:35 +0800 [thread overview]
Message-ID: <20211223032337.5198-1-yinxin.x@bytedance.com> (raw)
This patch sets fix 2 crash-consistency issues of fast commit.
First patch change to use ext4_ext_remove_space instead of
ext4_punch_hole during replay delete range procedure. This
avoid replay procedure being affeced by incorrect inode->i_size.
Second patch correct the trank range logic for ftruncte.
After testing this patch sets with xfstests-bld, in the "log" and
"quick" group with config "fast_commit" is selected. No regressions
was found.
Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
Xin Yin (2):
ext4: use ext4_ext_remove_space() for fast commit replay delete range
ext4: fast commit may miss tracking unwritten range during ftruncate
fs/ext4/fast_commit.c | 13 ++++++++-----
fs/ext4/inode.c | 3 +--
2 files changed, 9 insertions(+), 7 deletions(-)
--
2.20.1
next reply other threads:[~2021-12-23 3:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 3:23 Xin Yin [this message]
2021-12-23 3:23 ` [PATCH 1/2] ext4: use ext4_ext_remove_space() for fast commit replay delete range Xin Yin
2021-12-23 20:11 ` harshad shirwadkar
2022-02-01 20:33 ` Ritesh Harjani
2022-02-02 13:40 ` [External] " Xin Yin
2022-02-03 21:14 ` Ritesh Harjani
2022-02-04 11:36 ` Jan Kara
2022-02-05 10:40 ` Ritesh Harjani
2021-12-23 3:23 ` [PATCH 2/2] ext4: fast commit may miss tracking unwritten range during ftruncate Xin Yin
2021-12-23 20:11 ` harshad shirwadkar
2021-12-23 20:13 ` [PATCH 0/2] ext4: fast commit crash consistency issues harshad shirwadkar
2021-12-24 0:27 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223032337.5198-1-yinxin.x@bytedance.com \
--to=yinxin.x@bytedance.com \
--cc=adilger.kernel@dilger.ca \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).