From: Pavel Machek <pavel@ucw.cz>
To: Lukas Czerner <lczerner@redhat.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, "Jan Kara" <jack@suse.cz>,
"Darrick J. Wong" <djwong@kernel.org>,
"Luís Henriques" <lhenriques@suse.de>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jeroen van Wolffelaar" <jeroen@wolffelaar.nl>
Subject: Re: [PATCH v2] ext4: set csum seed in tmp inode while migrating to extents
Date: Tue, 28 Dec 2021 23:40:17 +0100 [thread overview]
Message-ID: <20211228224017.GA2242@duo.ucw.cz> (raw)
In-Reply-To: <20211217093534.2ug6e5cm37md2c3u@work>
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
Hi!
> > So the question is, is it worth it to continue supporting the migrate
> > feature, or should we just delete all of the migration code, and risk
> > users complaining that we've broken their use case? The chances of
> > that happening is admittedly low, and Linus's rule that "it's only
> > breaking userspace if a user complains" means we might very well get
> > away with it. :-)
>
> That's a very good summary Ted, thanks.
>
> Our rationale behind not supporting the migration was always the fact
> that we felt that backup was absolutely necessary before operation like
> this. When you already have up-to-date backup available you might as
> well create a fresh ext4 file system with all the advantages it brings
> and recover data from said backup. I think this is still a very
> reasonable approach.
Umm. Not really?
First... full backup/restore will take a _long_ time.
Second... if you do online migration, you have filesystem you are
quite unlikely to corrupt, and backup you are unlikely to use. If you
do backup/restore, you have to be _way_ more careful that backup media
is reliable etc.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-12-28 22:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 17:50 [PATCH v2] ext4: set csum seed in tmp inode while migrating to extents Luís Henriques
2021-12-15 0:49 ` Darrick J. Wong
2021-12-15 10:46 ` Luís Henriques
2021-12-15 11:28 ` Jan Kara
2021-12-15 14:12 ` Lukas Czerner
2021-12-15 15:37 ` Luís Henriques
2021-12-16 11:23 ` Luís Henriques
2021-12-16 18:32 ` Theodore Ts'o
2021-12-17 9:35 ` Lukas Czerner
2021-12-28 22:40 ` Pavel Machek [this message]
2021-12-30 6:56 ` Theodore Ts'o
2021-12-17 15:09 ` Jeroen van Wolffelaar
2022-01-06 4:41 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211228224017.GA2242@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=adilger.kernel@dilger.ca \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=jeroen@wolffelaar.nl \
--cc=lczerner@redhat.com \
--cc=lhenriques@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox