From: "Darrick J. Wong" <djwong@kernel.org>
To: Lukas Czerner <lczerner@redhat.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] common/rc: set maximum label length for ext4
Date: Mon, 31 Jan 2022 09:07:00 -0800 [thread overview]
Message-ID: <20220131170700.GA8288@magnolia> (raw)
In-Reply-To: <20211123101119.5112-1-lczerner@redhat.com>
On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote:
> Set maximum label length for ext4 in _label_get_max() to be able to test
> online file system label set/get ioctls.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> common/rc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/common/rc b/common/rc
> index 8e351f17..50d6d0bd 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -4545,6 +4545,9 @@ _label_get_max()
> f2fs)
> echo 255
> ;;
> + ext2|ext3|ext4)
> + echo 16
After reviewing the ext4 ondisk format, 16 is the correct value.
Though I wonder, what actually prevents generic/492 from running on old
kernels without GETLABEL support?
Either way this patch is ok, so...
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> + ;;
> *)
> _notrun "$FSTYP does not define maximum label length"
> ;;
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-01-31 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 10:11 [PATCH] common/rc: set maximum label length for ext4 Lukas Czerner
2021-11-28 14:33 ` Eryu Guan
2021-11-29 9:55 ` Lukas Czerner
2022-01-31 9:42 ` Lukas Czerner
2022-01-31 17:07 ` Darrick J. Wong [this message]
2022-01-31 20:46 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131170700.GA8288@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).