Linux EXT4 FS development
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Jan Kara <jack@suse.com>, Stephen Rothwell <sfr@canb.auug.org.au>,
	Andrew Morton <akpm@linux-foundation.org>,
	NeilBrown <neilb@suse.de>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ext2: remove unused pointer bdi
Date: Mon, 7 Feb 2022 15:46:12 +0100	[thread overview]
Message-ID: <20220207144612.zdczs7wxzbuk3ydr@quack3.lan> (raw)
In-Reply-To: <20220207134039.337197-1-colin.i.king@gmail.com>

On Mon 07-02-22 13:40:39, Colin Ian King wrote:
> The call to bdi_congested has been removed and so the bdi pointer
> is no longer required. Remove it.
> 
> Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() and related functions")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

I guess this change is in mm tree? So probably it is best if Andrew picks
it up.

								Honza

> ---
>  fs/ext2/ialloc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index d632764da240..998dd2ac8008 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
>  	unsigned long offset;
>  	unsigned long block;
>  	struct ext2_group_desc * gdp;
> -	struct backing_dev_info *bdi;
> -
> -	bdi = inode_to_bdi(inode);
>  
>  	block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
>  	gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
> -- 
> 2.34.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2022-02-07 15:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 13:40 [PATCH][next] ext2: remove unused pointer bdi Colin Ian King
2022-02-07 14:46 ` Jan Kara [this message]
2022-02-07 20:52   ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220207144612.zdczs7wxzbuk3ydr@quack3.lan \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=colin.i.king@gmail.com \
    --cc=jack@suse.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox