linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org, Stable <stable@vger.kernel.org>,
	Dave Chinner <dchinner@redhat.com>,
	Goldwyn Rodrigues <rgoldwyn@suse.com>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	Bob Peterson <rpeterso@redhat.com>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Theodore Ts'o <tytso@mit.edu>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Ritesh Harjani <riteshh@linux.ibm.com>,
	Johannes Thumshirn <jth@kernel.org>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-ext4@vger.kernel.org, cluster-devel@redhat.com,
	syzbot+0ed9f769264276638893@syzkaller.appspotmail.com
Subject: Re: [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"
Date: Thu, 10 Feb 2022 06:47:54 +0100	[thread overview]
Message-ID: <20220210054754.GB3293@lst.de> (raw)
In-Reply-To: <YgPk9HhIeFM43b/a@google.com>

On Wed, Feb 09, 2022 at 03:59:48PM +0000, Lee Jones wrote:
> > Well, maybe you should actually debug and try to understand what is
> > going on before blindly reverting random commits.
> 
> That is not a reasonable suggestion.

In that case we fudamentally disagree what "reasonable" means.

Sending a revert for a 2 year old commit based on a BUG in consumer of
that subsystem based on a really old kernel without any explanation
of why that revert is even directly related to the problem and not just
a casuality is what I would define as completely unreasable.

Please send a proper bug report to the ext4 maintainer first, and we
can work from there.

  parent reply	other threads:[~2022-02-10  5:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09  8:52 [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures" Lee Jones
2022-02-09 10:45 ` Damien Le Moal
2022-02-09 15:09 ` Christoph Hellwig
2022-02-09 15:20   ` Andreas Gruenbacher
2022-02-09 15:59   ` Lee Jones
2022-02-09 19:12     ` Matthew Wilcox
2022-02-09 19:25       ` Lee Jones
2022-02-10  5:47     ` Christoph Hellwig [this message]
2022-02-10  4:59 ` Darrick J. Wong
2022-02-10 10:15   ` Lee Jones
2022-02-11 14:37     ` Matthew Wilcox
2022-02-14 10:33       ` Lee Jones
2022-02-14 13:42         ` Christoph Hellwig
2022-02-14 14:11           ` Lee Jones
2022-02-14 14:24             ` Matthew Wilcox
2022-02-14 14:43               ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210054754.GB3293@lst.de \
    --to=hch@lst.de \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=damien.lemoal@wdc.com \
    --cc=darrick.wong@oracle.com \
    --cc=dchinner@redhat.com \
    --cc=jth@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=rgoldwyn@suse.com \
    --cc=riteshh@linux.ibm.com \
    --cc=rpeterso@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+0ed9f769264276638893@syzkaller.appspotmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).