From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89997C4332F for ; Thu, 10 Feb 2022 05:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234935AbiBJFsT (ORCPT ); Thu, 10 Feb 2022 00:48:19 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234428AbiBJFr7 (ORCPT ); Thu, 10 Feb 2022 00:47:59 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98E6E10CC; Wed, 9 Feb 2022 21:47:58 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 7187268B05; Thu, 10 Feb 2022 06:47:54 +0100 (CET) Date: Thu, 10 Feb 2022 06:47:54 +0100 From: Christoph Hellwig To: Lee Jones Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, Stable , Dave Chinner , Goldwyn Rodrigues , "Darrick J . Wong" , Bob Peterson , Damien Le Moal , Theodore Ts'o , Andreas Gruenbacher , Ritesh Harjani , Johannes Thumshirn , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, syzbot+0ed9f769264276638893@syzkaller.appspotmail.com Subject: Re: [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures" Message-ID: <20220210054754.GB3293@lst.de> References: <20220209085243.3136536-1-lee.jones@linaro.org> <20220209150904.GA22025@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Feb 09, 2022 at 03:59:48PM +0000, Lee Jones wrote: > > Well, maybe you should actually debug and try to understand what is > > going on before blindly reverting random commits. > > That is not a reasonable suggestion. In that case we fudamentally disagree what "reasonable" means. Sending a revert for a 2 year old commit based on a BUG in consumer of that subsystem based on a really old kernel without any explanation of why that revert is even directly related to the problem and not just a casuality is what I would define as completely unreasable. Please send a proper bug report to the ext4 maintainer first, and we can work from there.