From: Dave Chinner <david@fromorbit.com>
To: Artem Blagodarenko <artem.blagodarenko@gmail.com>
Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
Andrew Perepechko <andrew.perepechko@hpe.com>
Subject: Re: [PATCH] ext4: truncate during setxattr leads to kernel panic
Date: Sat, 26 Feb 2022 10:28:34 +1100 [thread overview]
Message-ID: <20220225232834.GR3061737@dread.disaster.area> (raw)
In-Reply-To: <20220225110413.1663-1-artem.blagodarenko@gmail.com>
On Fri, Feb 25, 2022 at 06:04:13AM -0500, Artem Blagodarenko wrote:
> @@ -1791,7 +1821,7 @@ static int ext4_xattr_set_entry(struct ext4_xattr_info *i,
> ret = 0;
> out:
> iput(old_ea_inode);
> - iput(new_ea_inode);
> + delayed_iput(old_ea_inode, diwork);
That looks broken....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2022-02-25 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 11:04 [PATCH] ext4: truncate during setxattr leads to kernel panic Artem Blagodarenko
2022-02-25 23:28 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225232834.GR3061737@dread.disaster.area \
--to=david@fromorbit.com \
--cc=adilger.kernel@dilger.ca \
--cc=andrew.perepechko@hpe.com \
--cc=artem.blagodarenko@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox