linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Song Liu <song@kernel.org>, "Theodore Ts'o" <tytso@mit.edu>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: [PATCH 04/10] dm-crypt: stop using bio_devname
Date: Fri,  4 Mar 2022 19:00:59 +0100	[thread overview]
Message-ID: <20220304180105.409765-5-hch@lst.de> (raw)
In-Reply-To: <20220304180105.409765-1-hch@lst.de>

Use the %pg format specifier to save on stack consuption and code size.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm-crypt.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
index a5006cb6ee8ad..e2b0af4a2ee84 100644
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -1364,11 +1364,10 @@ static int crypt_convert_block_aead(struct crypt_config *cc,
 	}
 
 	if (r == -EBADMSG) {
-		char b[BDEVNAME_SIZE];
 		sector_t s = le64_to_cpu(*sector);
 
-		DMERR_LIMIT("%s: INTEGRITY AEAD ERROR, sector %llu",
-			    bio_devname(ctx->bio_in, b), s);
+		DMERR_LIMIT("%pg: INTEGRITY AEAD ERROR, sector %llu",
+			    ctx->bio_in->bi_bdev, s);
 		dm_audit_log_bio(DM_MSG_PREFIX, "integrity-aead",
 				 ctx->bio_in, s, 0);
 	}
@@ -2169,11 +2168,10 @@ static void kcryptd_async_done(struct crypto_async_request *async_req,
 		error = cc->iv_gen_ops->post(cc, org_iv_of_dmreq(cc, dmreq), dmreq);
 
 	if (error == -EBADMSG) {
-		char b[BDEVNAME_SIZE];
 		sector_t s = le64_to_cpu(*org_sector_of_dmreq(cc, dmreq));
 
-		DMERR_LIMIT("%s: INTEGRITY AEAD ERROR, sector %llu",
-			    bio_devname(ctx->bio_in, b), s);
+		DMERR_LIMIT("%pg: INTEGRITY AEAD ERROR, sector %llu",
+			    ctx->bio_in->bi_bdev, s);
 		dm_audit_log_bio(DM_MSG_PREFIX, "integrity-aead",
 				 ctx->bio_in, s, 0);
 		io->error = BLK_STS_PROTECTION;
-- 
2.30.2


  parent reply	other threads:[~2022-03-04 18:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 18:00 remove bio_devname Christoph Hellwig
2022-03-04 18:00 ` [PATCH 01/10] block: fix and cleanup bio_check_ro Christoph Hellwig
2022-03-07  3:05   ` Chaitanya Kulkarni
2022-03-04 18:00 ` [PATCH 02/10] block: remove handle_bad_sector Christoph Hellwig
2022-03-07  3:05   ` Chaitanya Kulkarni
2022-03-04 18:00 ` [PATCH 03/10] pktcdvd: remove a pointless debug check in pkt_submit_bio Christoph Hellwig
2022-03-04 18:00 ` Christoph Hellwig [this message]
2022-03-07  3:07   ` [PATCH 04/10] dm-crypt: stop using bio_devname Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 05/10] dm-integrity: " Christoph Hellwig
2022-03-07  3:07   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 06/10] md-multipath: " Christoph Hellwig
2022-03-04 19:14   ` Song Liu
2022-03-07  3:07   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 07/10] raid1: " Christoph Hellwig
2022-03-04 19:14   ` Song Liu
2022-03-07  3:06   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 08/10] raid5-ppl: " Christoph Hellwig
2022-03-04 19:14   ` Song Liu
2022-03-04 18:01 ` [PATCH 09/10] ext4: " Christoph Hellwig
2022-03-07  3:08   ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 10/10] block: remove bio_devname Christoph Hellwig
2022-03-07  3:06   ` Chaitanya Kulkarni
2022-03-07 11:38 ` Johannes Thumshirn
2022-03-07 13:42 ` Jens Axboe
2022-03-07 16:45   ` Mike Snitzer
2022-03-07 16:48     ` Christoph Hellwig
2022-03-07 16:56       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304180105.409765-5-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).