Re: [PATCH v4 02/24] dept: Implement Dept(Dependency Tracker)

[kernel test robot <lkp@intel.com>]

Hi Byungchul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on linux/master linus/master v5.17-rc7]
[cannot apply to tip/locking/core hnaz-mm/master next-20220308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Byungchul-Park/DEPT-Dependency-Tracker/20220304-150943
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 25795ef6299f07ce3838f3253a9cb34f64efcfae
config: hexagon-randconfig-r022-20220307 (https://download.01.org/0day-ci/archive/20220309/202203091550.PnufQ7gO-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/387c58f459c6eb2a17a99b6c42ad57512a917d5d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Byungchul-Park/DEPT-Dependency-Tracker/20220304-150943
        git checkout 387c58f459c6eb2a17a99b6c42ad57512a917d5d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/target/ kernel/dependency/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/dependency/dept.c:2093:6: warning: no previous prototype for function '__dept_wait' [-Wmissing-prototypes]
   void __dept_wait(struct dept_map *m, unsigned long w_f, unsigned long ip,
        ^
   kernel/dependency/dept.c:2093:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void __dept_wait(struct dept_map *m, unsigned long w_f, unsigned long ip,
   ^
   static 
   In file included from kernel/dependency/dept.c:2532:
>> kernel/dependency/dept_hash.h:9:1: warning: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'unsigned long' [-Wformat]
   HASH(dep, 12)
   ^~~~~~~~~~~~~
   kernel/dependency/dept.c:2531:14: note: expanded from macro 'HASH'
                  #id, B2KB(sizeof(struct hlist_head) * (1UL << bits)));
                  ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/printk.h:519:34: note: expanded from macro 'pr_info'
           printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
   include/linux/printk.h:446:60: note: expanded from macro 'printk'
   #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
   include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
                   _p_func(_fmt, ##__VA_ARGS__);                           \
                           ~~~~    ^~~~~~~~~~~
   kernel/dependency/dept.c:2497:17: note: expanded from macro 'B2KB'
   #define B2KB(B) ((B) / 1024)
                   ^~~~~~~~~~~~
   In file included from kernel/dependency/dept.c:2532:
   kernel/dependency/dept_hash.h:10:1: warning: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'unsigned long' [-Wformat]
   HASH(class, 12)
   ^~~~~~~~~~~~~~~
   kernel/dependency/dept.c:2531:14: note: expanded from macro 'HASH'
                  #id, B2KB(sizeof(struct hlist_head) * (1UL << bits)));
                  ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/printk.h:519:34: note: expanded from macro 'pr_info'
           printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
   include/linux/printk.h:446:60: note: expanded from macro 'printk'
   #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
   include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
                   _p_func(_fmt, ##__VA_ARGS__);                           \
                           ~~~~    ^~~~~~~~~~~
   kernel/dependency/dept.c:2497:17: note: expanded from macro 'B2KB'
   #define B2KB(B) ((B) / 1024)
                   ^~~~~~~~~~~~
   3 warnings generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
   Selected by
   - DEPT && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && !MIPS && !PPC && !ARM && !S390 && !MICROBLAZE && !ARC && !X86


vim +/__dept_wait +2093 kernel/dependency/dept.c

  2092	
> 2093	void __dept_wait(struct dept_map *m, unsigned long w_f, unsigned long ip,
  2094			 const char *w_fn, int ne)
  2095	{
  2096		int e;
  2097	
  2098		/*
  2099		 * Be as conservative as possible. In case of mulitple waits for
  2100		 * a single dept_map, we are going to keep only the last wait's
  2101		 * wgen for simplicity - keeping all wgens seems overengineering.
  2102		 *
  2103		 * Of course, it might cause missing some dependencies that
  2104		 * would rarely, probabily never, happen but it helps avoid
  2105		 * false positive report.
  2106		 */
  2107		for_each_set_bit(e, &w_f, DEPT_MAX_SUBCLASSES_EVT) {
  2108			struct dept_class *c;
  2109			struct dept_key *k;
  2110	
  2111			k = m->keys ?: &m->keys_local;
  2112			c = check_new_class(&m->keys_local, k,
  2113					    map_sub(m, e), m->name);
  2114			if (!c)
  2115				continue;
  2116	
  2117			add_wait(c, ip, w_fn, ne);
  2118		}
  2119	}
  2120	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org