Re: [PATCHv3 0/4] generic: Add some tests around journal replay/recoveryloop

Zorro Lang
2022-03-31T14:59:27Z

On Thu, Mar 31, 2022 at 06:24:19PM +0530, Ritesh Harjani wrote:
> Hello,

Hi,

Your below patches looks like not pure text format, they might contain
binary character or some special characers, looks like the "^M" [1].

So please check how you generate/edit/send these patches, make sure
they're pure text for Linux then send again.

Thanks,
Zorro

[1]
# cat -A /path/to/your_patch
index 95752d3b..5e73cff9 100755^M$
--- a/tests/generic/468^M$
+++ b/tests/generic/468^M$
@@ -34,6 +34,13 @@ _scratch_mkfs >/dev/null 2>&1^M$
_require_metadata_journaling $SCRATCH_DEV^M$
_scratch_mount^M$
^M$
+# blocksize and fact are used in the last case of the fsync/fdatasync test.^M$
+# This is mainly trying to test recovery operation in case where the data^M$
+# blocks written, exceeds the default flex group size (32768*4096*16) in ext4.^M$
+blocks=32768^M$
+blocksize=4096^M$
+fact=18^M$
+^M$
...
...

>
> The ext4 fast_commit kernel fix has landed into mainline tree [1].
> In this v3, I have addressed review comments from Darrick.
> Does this looks good to be picked up?
>
> I have tested ext4 1k, 4k (w & w/o fast_commit). Also tested other FS with
> default configs (like xfs, btrfs, f2fs). No surprises were seen.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bfdc502a4a4c058bf4cbb1df0c297761d528f54d
>
> -ritesh
>
> Changelogs:
> ===========
>
> v2 => v3
> =========
> 1. Addressed review comments from Darrick.
> 2. Rebased to latest master.
>
> v1 => v2
> =========
> Sending v2 with tests/ext4/ converted to tests/generic/
> (although I had not received any review comments on v1).
> It seems all of the tests which I had sent in v1 are not ext4 specific anyways.
> So in v2, I have made those into tests/generic/.
>
> Summary
> =========
> These are some of the tests which when tested with ext4 fast_commit feature
> w/o kernel fixes, could cause tests failures and/or KASAN bug (generic/486).
>
> I gave these tests a run with default xfs, btrfs and f2fs configs (along with
> ext4). No surprises observed.
>
> [v2]: https://lore.kernel.org/all/cover.1647342932.git.riteshh@linux.ibm.com/
> [v1]: https://lore.kernel.org/all/cover.1644070604.git.riteshh@linux.ibm.com/
>
>
> Ritesh Harjani (4):
> generic/468: Add another falloc test entry
> common/punch: Add block_size argument to _filter_fiemap_**
> generic/678: Add a new shutdown recovery test
> generic/679: Add a test to check unwritten extents tracking
>
> common/punch | 9 +++---
> tests/generic/468 | 8 +++++
> tests/generic/468.out | 2 ++
> tests/generic/678 | 72 +++++++++++++++++++++++++++++++++++++++++++
> tests/generic/678.out | 7 +++++
> tests/generic/679 | 65 ++++++++++++++++++++++++++++++++++++++
> tests/generic/679.out | 6 ++++
> 7 files changed, 165 insertions(+), 4 deletions(-)
> create mode 100755 tests/generic/678
> create mode 100644 tests/generic/678.out
> create mode 100755 tests/generic/679
> create mode 100644 tests/generic/679.out
>
> --
> 2.31.1
>