From: "Darrick J. Wong" <djwong@kernel.org>
To: Matthew G McGovern <matthew@mcgov.dev>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix
Date: Thu, 14 Apr 2022 18:38:28 -0700 [thread overview]
Message-ID: <20220415013828.GA16986@magnolia> (raw)
In-Reply-To: <pvZcd0oHwCKt92jKr8OMUPT_Y9-UIziM36-74bg8vvEEOKgIW6_KiAdMKw7eRn5L8Tc4AKOSOOcaFmcVCAQ1TYM7gmYI0ZNmNqX_7tkqIE8=@mcgov.dev>
On Fri, Apr 15, 2022 at 12:50:56AM +0000, Matthew G McGovern wrote:
> From: "Matthew G. McGovern" <matthew@mcgov.dev>
> Date: Wed, 13 Apr 2022 15:48:15 -0700
> Subject: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix
>
> An ext4 struct has the wrong array size for a field in the docs.
>
> - Document correct array size (3) for ext4_xattr_header.h_reserved
>
> Signed-off-by: Matthew G. McGovern <matthew@mcgov.dev>
Yup. Thanks for the correction.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> Documentation/filesystems/ext4/attributes.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/attributes.rst b/Documentation/filesystems/ext4/attributes.rst
> index 54386a010a8d..871d2da7a0a9 100644
> --- a/Documentation/filesystems/ext4/attributes.rst
> +++ b/Documentation/filesystems/ext4/attributes.rst
> @@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
> - Checksum of the extended attribute block.
> * - 0x14
> - \_\_u32
> - - h\_reserved[2]
> + - h\_reserved[3]
> - Zero.
>
> The checksum is calculated against the FS UUID, the 64-bit block number
>
> base-commit: 96485e4462604744d66bf4301557d996d80b85eb
> --
> 2.25.1
next prev parent reply other threads:[~2022-04-15 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 0:50 [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix Matthew G McGovern
2022-04-15 1:38 ` Darrick J. Wong [this message]
2022-04-16 1:07 ` wangjianjian (C)
2022-04-18 15:28 ` Matthew G McGovern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415013828.GA16986@magnolia \
--to=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=matthew@mcgov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox