From: Fengnan Chang <changfengnan@vivo.com>
To: jaegeuk@kernel.org, chao@kernel.org, tytso@mit.edu,
adilger.kernel@dilger.ca, axboe@kernel.dk
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, linux-block@vger.kernel.org,
Fengnan Chang <changfengnan@vivo.com>
Subject: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt
Date: Mon, 18 Apr 2022 14:33:11 +0800 [thread overview]
Message-ID: <20220418063312.63181-2-changfengnan@vivo.com> (raw)
In-Reply-To: <20220418063312.63181-1-changfengnan@vivo.com>
Notify when mount filesystem with -o inlinecrypt option, but the device
not support inlinecrypt.
Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
---
fs/f2fs/f2fs.h | 18 ++++++++++++++++++
fs/f2fs/super.c | 7 +++++++
2 files changed, 25 insertions(+)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 38cbed0f544e..dc27a708c283 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -27,6 +27,7 @@
#include <linux/fscrypt.h>
#include <linux/fsverity.h>
+#include <linux/blk-crypto.h>
struct pagevec;
@@ -4395,6 +4396,23 @@ static inline bool f2fs_realtime_discard_enable(struct f2fs_sb_info *sbi)
f2fs_hw_should_discard(sbi);
}
+#ifdef CONFIG_FS_ENCRYPTION_INLINE_CRYPT
+static inline bool f2fs_hw_support_crypto(struct f2fs_sb_info *sbi)
+{
+ int i;
+
+ if (!f2fs_is_multi_device(sbi))
+ if (!blk_crypto_supported(bdev_get_queue(sbi->sb->s_bdev)))
+ return false;
+
+ for (i = 0; i < sbi->s_ndevs; i++)
+ if (!blk_crypto_supported(bdev_get_queue(FDEV(i).bdev)))
+ return false;
+
+ return true;
+}
+#endif
+
static inline bool f2fs_hw_is_readonly(struct f2fs_sb_info *sbi)
{
int i;
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 4368f90571bd..624d8791b82d 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1275,6 +1275,13 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
}
#endif
+#ifdef CONFIG_FS_ENCRYPTION_INLINE_CRYPT
+ if ((sb->s_flags & SB_INLINECRYPT) && !f2fs_hw_support_crypto(sbi)) {
+ f2fs_info(sbi, "mounting with \"inlinecrypt\" option, but the device does not support inlinecrypt");
+ sb->s_flags &= ~SB_INLINECRYPT;
+ }
+#endif
+
if (F2FS_IO_SIZE_BITS(sbi) && !f2fs_lfs_mode(sbi)) {
f2fs_err(sbi, "Should set mode=lfs with %uKB-sized IO",
F2FS_IO_SIZE_KB(sbi));
--
2.32.0
next prev parent reply other threads:[~2022-04-18 6:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 6:33 [PATCH 1/3] blk-crypto: introduce blk_crypto_supported Fengnan Chang
2022-04-18 6:33 ` Fengnan Chang [this message]
2022-04-18 7:22 ` [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt Eric Biggers
2022-04-18 7:34 ` 常凤楠
2022-04-18 22:27 ` Eric Biggers
2022-04-18 22:43 ` Theodore Ts'o
2022-04-19 3:14 ` 常凤楠
2022-04-19 3:18 ` Eric Biggers
2022-04-19 3:22 ` 常凤楠
2022-04-18 6:33 ` [PATCH 3/3] ext4: " Fengnan Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220418063312.63181-2-changfengnan@vivo.com \
--to=changfengnan@vivo.com \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox