From: Jan Kara <jack@suse.cz>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment
Date: Thu, 12 May 2022 19:37:27 +0200 [thread overview]
Message-ID: <20220512173727.azszrl272bxjxheb@quack3.lan> (raw)
In-Reply-To: <20220512075432.31763-1-yang.lee@linux.alibaba.com>
On Thu 12-05-22 15:54:32, Yang Li wrote:
> Add the description of @folio and remove @page in function kernel-doc
> comment to remove warnings found by running scripts/kernel-doc, which
> is caused by using 'make W=1'.
>
> fs/jbd2/transaction.c:2149: warning: Function parameter or member
> 'folio' not described in 'jbd2_journal_try_to_free_buffers'
> fs/jbd2/transaction.c:2149: warning: Excess function parameter 'page'
> description in 'jbd2_journal_try_to_free_buffers'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
OK, but isn't this on linux-next only? Because I don't see the 'folio'
parameter in current Linus' tree yet.
Honza
> ---
> fs/jbd2/transaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index e49bb0938376..e9c308ae475f 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -2114,7 +2114,7 @@ __journal_try_to_free_buffer(journal_t *journal, struct buffer_head *bh)
> /**
> * jbd2_journal_try_to_free_buffers() - try to free page buffers.
> * @journal: journal for operation
> - * @page: to try and free
> + * @folio: Folio to detach data from.
> *
> * For all the buffers on this page,
> * if they are fully written out ordered data, move them onto BUF_CLEAN
> --
> 2.20.1.7.g153144c
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-05-12 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 7:54 [PATCH -next] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment Yang Li
2022-05-12 17:37 ` Jan Kara [this message]
2022-06-16 14:53 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512173727.azszrl272bxjxheb@quack3.lan \
--to=jack@suse.cz \
--cc=abaci@linux.alibaba.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox