Re: [PATCHv2 2/3] ext4: Cleanup function defs from ext4.h into crypto.c

Eric Biggers
2022-05-15T03:40:22Z

On Sat, May 14, 2022 at 10:52:47PM +0530, Ritesh Harjani wrote:
> diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c
[...]
> +int ext4_fname_setup_filename(struct inode *dir, const struct qstr *iname,
> + int lookup, struct ext4_filename *fname)
> +{
[...]
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
[...]
> +int ext4_fname_setup_filename(struct inode *dir,
> + const struct qstr *iname, int lookup,
> + struct ext4_filename *fname);

Very minor nit: the above declaration can be formatted on 2 lines, the same as
the definition.

Otherwise this patch looks fine. I think that filename handling in ext4 in
general is still greatly in need of some cleanups, considering that ext4 now has
to support all combinations of encryption and casefolding. f2fs does it in a
somewhat cleaner way, IMO. And it's possible that would lead us down a slightly
different path. But this is an improvement for now.

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric