From: Liu Peibao <liupeibao@163.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
liupeibao@163.com
Subject: [PATCH 2/2] ext4: rename temporary variables in ext4_finish_bio()
Date: Wed, 18 May 2022 20:01:37 +0800 [thread overview]
Message-ID: <20220518120137.2544-2-liupeibao@163.com> (raw)
In-Reply-To: <20220518120137.2544-1-liupeibao@163.com>
The temporary variable bio_start and bio_end are confusingly
misnamed. Rename them with bvec_ instead of bio_ to indicate
what they really are.
Signed-off-by: Liu Peibao <liupeibao@163.com>
---
fs/ext4/page-io.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index fd55e11c8391..dd0a7f734d7f 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -106,8 +106,8 @@ static void ext4_finish_bio(struct bio *bio)
struct page *page = bvec->bv_page;
struct page *bounce_page = NULL;
struct buffer_head *bh, *head;
- unsigned int bio_start = bvec->bv_offset;
- unsigned int bio_end = bio_start + bvec->bv_len;
+ unsigned int bvec_start = bvec->bv_offset;
+ unsigned int bvec_end = bvec_start + bvec->bv_len;
unsigned int under_io = 0;
unsigned long flags;
@@ -127,8 +127,8 @@ static void ext4_finish_bio(struct bio *bio)
*/
spin_lock_irqsave(&head->b_uptodate_lock, flags);
do {
- if (bh_offset(bh) < bio_start ||
- bh_offset(bh) + bh->b_size > bio_end) {
+ if (bh_offset(bh) < bvec_start ||
+ bh_offset(bh) + bh->b_size > bvec_end) {
if (buffer_async_write(bh))
under_io++;
continue;
--
2.20.1
next prev parent reply other threads:[~2022-05-18 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 12:01 [PATCH 1/2] ext4: page-io: use 'unsigned int' to bare use of 'unsigned' Liu Peibao
2022-05-18 12:01 ` Liu Peibao [this message]
2022-06-16 14:49 ` Theodore Ts'o
2022-06-19 3:21 ` Liu Peibao
2022-06-19 18:18 ` Theodore Ts'o
2022-06-21 14:28 ` Liu Peibao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518120137.2544-2-liupeibao@163.com \
--to=liupeibao@163.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox