From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.com>,
Dave Kleikamp <shaggy@kernel.org>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
jfs-discussion@lists.sourceforge.net
Subject: Re: [PATCH 4/5] fs: don't call ->writepage from __mpage_writepage
Date: Thu, 9 Jun 2022 19:31:19 +0200 [thread overview]
Message-ID: <20220609173119.b34yp6ey6ybokfdl@quack3.lan> (raw)
In-Reply-To: <20220608150451.1432388-5-hch@lst.de>
On Wed 08-06-22 17:04:50, Christoph Hellwig wrote:
> All callers of mpage_writepage use block_write_full_page as their
> ->writepage implementation, so hard code that.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Similarly here NTFS (fs/ntfs3/) seems to have some non-trivial stuff besides
block_write_full_page()...
Honza
> ---
> fs/mpage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/mpage.c b/fs/mpage.c
> index 31a97a0acf5f5..a354ef2b4b4eb 100644
> --- a/fs/mpage.c
> +++ b/fs/mpage.c
> @@ -624,7 +624,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc,
> /*
> * The caller has a ref on the inode, so *mapping is stable
> */
> - ret = mapping->a_ops->writepage(page, wbc);
> + ret = block_write_full_page(page, mpd->get_block, wbc);
> mapping_set_error(mapping, ret);
> out:
> mpd->bio = bio;
> --
> 2.30.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-06-09 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 15:04 remove the nobh helpers Christoph Hellwig
2022-06-08 15:04 ` [PATCH 1/5] ext2: remove nobh support Christoph Hellwig
2022-06-08 16:39 ` Matthew Wilcox
2022-06-09 3:54 ` Christoph Hellwig
2022-06-09 17:32 ` Jan Kara
2022-06-08 15:04 ` [PATCH 2/5] jfs: stop using the nobh helper Christoph Hellwig
2022-06-08 15:04 ` [PATCH 3/5] fs: remove the nobh helpers Christoph Hellwig
2022-06-09 17:33 ` Jan Kara
2022-06-08 15:04 ` [PATCH 4/5] fs: don't call ->writepage from __mpage_writepage Christoph Hellwig
2022-06-09 17:31 ` Jan Kara [this message]
2022-06-10 8:00 ` Christoph Hellwig
2022-06-08 15:04 ` [PATCH 5/5] fs: remove the NULL get_block case in mpage_writepages Christoph Hellwig
2022-06-09 17:25 ` Jan Kara
2022-06-10 8:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609173119.b34yp6ey6ybokfdl@quack3.lan \
--to=jack@suse.cz \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox