From: Ritesh Harjani <ritesh.list@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Ted Tso <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/10 v2] ext4: Fix possible fs corruption due to xattr races
Date: Thu, 16 Jun 2022 17:24:40 +0530 [thread overview]
Message-ID: <20220616115440.ryjyecrwprgfoxp2@riteshh-domain> (raw)
In-Reply-To: <20220614124146.21594-1-jack@suse.cz>
On 22/06/14 06:05PM, Jan Kara wrote:
> Hello,
>
> this is the second version of my patches to fix the race in ext4 xattr handling
> that led to assertion failure in jbd2 Ritesh has reported. The series is
> completely reworked. This time it passes beating with "stress-ng --xattr 16".
> Also I'm somewhat happier about the current solution because, although it is
> still not trivial to use mbcache correctly, it is at least harder to use it
> in a racy way :). Please let me know what you think about this series.
I have tested this on my setup where I was able to reproduce the problem with
stress-ng. It ran for several hours and also passed fstests (quick).
So feel free to -
Tested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
-ritesh
>
> Changes since v1:
> * Reworked the series to fix all corner cases and make API less errorprone.
>
> Honza
>
> Previous versions:
> Link: http://lore.kernel.org/r/20220606142215.17962-1-jack@suse.cz # v1
next prev parent reply other threads:[~2022-06-16 11:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 16:05 [PATCH 0/10 v2] ext4: Fix possible fs corruption due to xattr races Jan Kara
2022-06-14 16:05 ` [PATCH 01/10] mbcache: Don't reclaim used entries Jan Kara
2022-06-16 14:22 ` Ritesh Harjani
2022-06-16 17:25 ` Jan Kara
2022-06-14 16:05 ` [PATCH 02/10] mbcache: Add functions to delete entry if unused Jan Kara
2022-06-16 14:47 ` Ritesh Harjani
2022-06-16 17:28 ` Jan Kara
2022-06-14 16:05 ` [PATCH 03/10] ext4: Remove EA inode entry from mbcache on inode eviction Jan Kara
2022-06-16 15:01 ` Ritesh Harjani
2022-06-16 17:30 ` Jan Kara
2022-06-14 16:05 ` [PATCH 04/10] ext4: Unindent codeblock in ext4_xattr_block_set() Jan Kara
2022-06-14 16:05 ` [PATCH 05/10] ext4: Fix race when reusing xattr blocks Jan Kara
2022-06-14 16:05 ` [PATCH 06/10] ext2: Factor our freeing of xattr block reference Jan Kara
2022-06-14 16:05 ` [PATCH 07/10] ext2: Unindent codeblock in ext2_xattr_set() Jan Kara
2022-06-14 16:05 ` [PATCH 08/10] ext2: Avoid deleting xattr block that is being reused Jan Kara
2022-06-14 16:05 ` [PATCH 09/10] mbcache: Remove mb_cache_entry_delete() Jan Kara
2022-06-14 16:05 ` [PATCH 10/10] mbcache: Automatically delete entries from cache on freeing Jan Kara
2022-06-16 11:54 ` Ritesh Harjani [this message]
2022-06-16 12:49 ` [PATCH 0/10 v2] ext4: Fix possible fs corruption due to xattr races Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616115440.ryjyecrwprgfoxp2@riteshh-domain \
--to=ritesh.list@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox