From: Eric Biggers <ebiggers@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, linux-fscrypt@vger.kernel.org,
Lukas Czerner <lczerner@redhat.com>
Subject: [xfstests PATCH v2] ext4/053: test changing test_dummy_encryption on remount
Date: Thu, 23 Jun 2022 11:41:13 -0700 [thread overview]
Message-ID: <20220623184113.330183-1-ebiggers@kernel.org> (raw)
From: Eric Biggers <ebiggers@google.com>
The test_dummy_encryption mount option isn't supposed to be settable or
changeable via a remount, so add test cases for this. This is a
regression test for a bug that was introduced in Linux v5.17 and fixed
in v5.19-rc3 by commit 85456054e10b ("ext4: fix up test_dummy_encryption
handling for new mount API").
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
v2: added info about fixing commit, and added a Reviewed-by tag
tests/ext4/053 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/ext4/053 b/tests/ext4/053
index 23e553c5..555e474e 100755
--- a/tests/ext4/053
+++ b/tests/ext4/053
@@ -685,6 +685,9 @@ for fstype in ext2 ext3 ext4; do
mnt test_dummy_encryption=v2
not_mnt test_dummy_encryption=bad
not_mnt test_dummy_encryption=
+ # Can't be set or changed on remount.
+ mnt_then_not_remount defaults test_dummy_encryption
+ mnt_then_not_remount test_dummy_encryption=v1 test_dummy_encryption=v2
do_mkfs -O ^encrypt $SCRATCH_DEV ${SIZE}k
fi
not_mnt test_dummy_encryption
base-commit: 0882b0913eae6fd6d2010323da1dde0ff96bf7d4
--
2.36.1
next reply other threads:[~2022-06-23 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 18:41 Eric Biggers [this message]
2022-06-24 6:16 ` [xfstests PATCH v2] ext4/053: test changing test_dummy_encryption on remount Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623184113.330183-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox