Re: [PATCH v6 06/14] mm: add device coherent checker to is_pinnable_page

David Hildenbrand
2022-06-28T10:41:50Z

On 28.06.22 02:14, Alex Sierra wrote:
> is_device_coherent checker was added to is_pinnable_page and renamed
> to is_longterm_pinnable_page. The reason is that device coherent
> pages are not supported for longterm pinning.
>
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
> ---
> include/linux/memremap.h | 25 +++++++++++++++++++++++++
> include/linux/mm.h | 24 ------------------------
> mm/gup.c | 5 ++---
> mm/gup_test.c | 4 ++--
> mm/hugetlb.c | 2 +-
> 5 files changed, 30 insertions(+), 30 deletions(-)

Rename of the function should be a separate cleanup patch before any
other changes, and the remaining change should be squashed into patch
#1, to logically make sense, because it still states "no one should be
allowed to pin such memory so that it can always be evicted."

Or am I missing something?

--
Thanks,

David / dhildenb