public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	"Jack Wang" <jinpu.wang@ionos.com>, "Song Liu" <song@kernel.org>,
	"Theodore Ts'o" <tytso@mit.edu>,
	"Andreas Dilger" <adilger.kernel@dilger.ca>,
	"Jan Kara" <jack@suse.com>, "Mark Fasheh" <mark@fasheh.com>,
	"Joel Becker" <jlbec@evilplan.org>,
	"Joseph Qi" <joseph.qi@linux.alibaba.com>,
	linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
	linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org,
	ocfs2-devel@oss.oracle.com
Subject: [PATCH 1/9] block: stop using bdevname in bdev_write_inode
Date: Wed, 13 Jul 2022 07:53:09 +0200	[thread overview]
Message-ID: <20220713055317.1888500-2-hch@lst.de> (raw)
In-Reply-To: <20220713055317.1888500-1-hch@lst.de>

Just use the %pg format specifier instead.  Also reformat the
printk statement to be more readable.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/bdev.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/block/bdev.c b/block/bdev.c
index 5fe06c1f2def4..ce05175e71cea 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -54,12 +54,10 @@ static void bdev_write_inode(struct block_device *bdev)
 	while (inode->i_state & I_DIRTY) {
 		spin_unlock(&inode->i_lock);
 		ret = write_inode_now(inode, true);
-		if (ret) {
-			char name[BDEVNAME_SIZE];
-			pr_warn_ratelimited("VFS: Dirty inode writeback failed "
-					    "for block device %s (err=%d).\n",
-					    bdevname(bdev, name), ret);
-		}
+		if (ret)
+			pr_warn_ratelimited(
+	"VFS: Dirty inode writeback failed for block device %pg (err=%d).\n",
+				bdev, ret);
 		spin_lock(&inode->i_lock);
 	}
 	spin_unlock(&inode->i_lock);
-- 
2.30.2


  reply	other threads:[~2022-07-13  5:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13  5:53 remove bdevname Christoph Hellwig
2022-07-13  5:53 ` Christoph Hellwig [this message]
2022-07-13  5:53 ` [PATCH 2/9] block: stop using bdevname in __blkdev_issue_discard Christoph Hellwig
2022-07-13  5:53 ` [PATCH 3/9] drbd: stop using bdevname in drbd_report_io_error Christoph Hellwig
2022-07-13 12:25   ` Christoph Böhmwalder
2022-07-13  5:53 ` [PATCH 4/9] pktcdvd: stop using bdevname in pkt_seq_show Christoph Hellwig
2022-07-13  5:53 ` [PATCH 5/9] pktcdvd: stop using bdevname in pkt_new_dev Christoph Hellwig
2022-07-13  5:53 ` [PATCH 6/9] rnbd-srv: remove the name field from struct rnbd_dev Christoph Hellwig
2022-07-13  7:03   ` Jinpu Wang
2022-07-13  5:53 ` [PATCH 7/9] ocfs2/cluster: remove the hr_dev_name field from struct o2hb_region Christoph Hellwig
2022-07-13 22:45   ` Joel Becker
2022-07-13  5:53 ` [PATCH 8/9] ext4: only initialize mmp_bdevname once Christoph Hellwig
2022-07-14 14:54   ` Theodore Ts'o
2022-07-13  5:53 ` [PATCH 9/9] block: remove bdevname Christoph Hellwig
2022-07-13  7:27 ` Johannes Thumshirn
2022-07-13  9:30 ` Chaitanya Kulkarni
2022-07-13 15:05 ` Jan Kara
2022-07-14 16:28 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713055317.1888500-2-hch@lst.de \
    --to=hch@lst.de \
    --cc=adilger.kernel@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=christoph.boehmwalder@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=haris.iqbal@ionos.com \
    --cc=jack@suse.com \
    --cc=jinpu.wang@ionos.com \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=song@kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox