From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64865C19F2D for ; Sat, 6 Aug 2022 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232012AbiHFOgS (ORCPT ); Sat, 6 Aug 2022 10:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbiHFOgR (ORCPT ); Sat, 6 Aug 2022 10:36:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 39509DFC6 for ; Sat, 6 Aug 2022 07:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659796575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nEiFrT8pUfGEdF80sgqt23VsfWyfMiuRGEYUmc8/30c=; b=StbAmVpvES4Mx1/uCNDknd2kFbJi/w2ckVE8Sn84fYyWzI/TLF6w3B0nvqXpjWD3fuutat w+gTRsBF3yWxLHLCHE1YilUxAULPvDzbBTVhgzDlD/qC6tIa8dCSMWDYUXYXvcgrcNj5VV Tt+5Bi1P5ZsFz0uCDDNRmpJqrfsgK1E= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-551-_7oo3kC2PUW4LJJJwQwvcA-1; Sat, 06 Aug 2022 10:36:14 -0400 X-MC-Unique: _7oo3kC2PUW4LJJJwQwvcA-1 Received: by mail-qv1-f69.google.com with SMTP id k17-20020ad44511000000b00478bd83e375so2811609qvu.17 for ; Sat, 06 Aug 2022 07:36:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nEiFrT8pUfGEdF80sgqt23VsfWyfMiuRGEYUmc8/30c=; b=8QjisvBP0tL8mNuxFMFno4VNRXljRX8WGZolXPFuT4zli4rl1kR1x3ixFbMe3xNmPI MEN5SFFXSUvpQnCY1EEfjdYoDXlDkYUTs2jBDmLUA5voSz9SJAHZZdhaenHEUqy7B7zC EJoJPopAXNWuuQmI8yivU5KhswzG9kXY0CHFC4nce+kIfkgUo1yurv6PYSjMfKOk4Q5V yqx6MlOX9mEUntNDKTrNMzRJPojS7yd1OXxlbgOeWRbqkPoZDsxS/YlETT4ptPVW0tDJ wHRXjL5zLRYVilrWTDrEHekelWKOd0C/PoY6lGOs+TEOkoneOhtSspSMJIzk46gBd7zq ysTg== X-Gm-Message-State: ACgBeo2rGgcjk/VEY9souSjELtMgA7VzuWcGfof/T2Xx1cQvJd61FVl1 CPVVoBpxxkkp8Z99vNIlKcw1OPeeqRA4sGSn8a+GQzGp4fMwat9tX7rZFBkDCur7ivQUQjsydUN RbuWFWezJXYuP+9nsWQmFPQ== X-Received: by 2002:ac8:5793:0:b0:342:ea28:742f with SMTP id v19-20020ac85793000000b00342ea28742fmr3541693qta.177.1659796573513; Sat, 06 Aug 2022 07:36:13 -0700 (PDT) X-Google-Smtp-Source: AA6agR5Edqgd5tEma8Bbe0qmCrc7D7VQUC2Kd1HRUpHkIo359q3oDb/C2ul7wCAHGRuyZNWLp8tMpQ== X-Received: by 2002:ac8:5793:0:b0:342:ea28:742f with SMTP id v19-20020ac85793000000b00342ea28742fmr3541671qta.177.1659796573204; Sat, 06 Aug 2022 07:36:13 -0700 (PDT) Received: from zlang-mailbox ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id i14-20020a05620a248e00b006b57b63a8ddsm5295002qkn.122.2022.08.06.07.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 07:36:12 -0700 (PDT) Date: Sat, 6 Aug 2022 22:36:06 +0800 From: Zorro Lang To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, tytso@mit.edu, linux-ext4@vger.kernel.org Subject: Re: [PATCHSET 0/3] fstests: refactor ext4-specific code Message-ID: <20220806143606.kd7ikbdjntugcpp4@zlang-mailbox> References: <165950050051.198922.13423077997881086438.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165950050051.198922.13423077997881086438.stgit@magnolia> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Aug 02, 2022 at 09:21:40PM -0700, Darrick J. Wong wrote: > Hi all, > > This series aims to make it so that fstests can install device mapper > filters for external log devices. Before we can do that, however, we > need to change fstests to pass the device path of the jbd2 device to > mount and mkfs. Before we can do /that/, refactor all the ext4-specific > code out of common/rc into a separate common/ext4 file. > > If you're going to start using this mess, you probably ought to just > pull from my git trees, which are linked below. > > This is an extraordinary way to destroy everything. Enjoy! > Comments and questions are, as always, welcome. > > --D > > fstests git tree: > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=refactor-ext4-helpers > --- Hi Darrick, There're 3 failures[1] if test ext4 with external logdev, after merging this patchset. The g/629 is always failed with or without this patchset, it fails if test with external logdev. The g/250 and g/252 fail due to _scratch_mkfs_sized doesn't use common ext4 mkfs helper, so can't deal with SCRATCH_LOGDEV well. Thanks, Zorro [1] SECTION -- logdev FSTYP -- ext4 PLATFORM -- Linux/x86_64 hp-dl380pg8-01 5.19.0-0.rc2.21.fc37.x86_64+debug #1 SMP PREEMPT_DYNAMIC Mon Jun 13 14:55:18 UTC 2022 MKFS_OPTIONS -- -F -J device=/dev/loop0 /dev/sda3 MOUNT_OPTIONS -- -o acl,user_xattr -o context=system_u:object_r:root_t:s0 -o journal_path=/dev/loop0 /dev/sda3 /mnt/scratch generic/250 2s ... - output mismatch (see /root/git/xfstests/results//logdev/generic/250.out.bad) --- tests/generic/250.out 2022-04-29 23:07:23.262498285 +0800 +++ /root/git/xfstests/results//logdev/generic/250.out.bad 2022-08-06 22:26:45.179294149 +0800 @@ -1,9 +1,19 @@ QA output created by 250 Format and mount +umount: /mnt/scratch: not mounted. +mount: /mnt/scratch: wrong fs type, bad option, bad superblock on /dev/mapper/error-test, missing codepage or helper program, or other error. + dmesg(1) may have more information after failed mount system call. Create the original files +umount: /mnt/scratch: not mounted. ... (Run 'diff -u /root/git/xfstests/tests/generic/250.out /root/git/xfstests/results//logdev/generic/250.out.bad' to see the entire diff) generic/252 2s ... - output mismatch (see /root/git/xfstests/results//logdev/generic/252.out.bad) --- tests/generic/252.out 2022-04-29 23:07:23.264498308 +0800 +++ /root/git/xfstests/results//logdev/generic/252.out.bad 2022-08-06 22:26:48.495330525 +0800 @@ -1,10 +1,19 @@ QA output created by 252 Format and mount +umount: /mnt/scratch: not mounted. +mount: /mnt/scratch: wrong fs type, bad option, bad superblock on /dev/mapper/error-test, missing codepage or helper program, or other error. + dmesg(1) may have more information after failed mount system call. Create the original files +umount: /mnt/scratch: not mounted. ... (Run 'diff -u /root/git/xfstests/tests/generic/252.out /root/git/xfstests/results//logdev/generic/252.out.bad' to see the entire diff) generic/629 3s ... - output mismatch (see /root/git/xfstests/results//logdev/generic/629.out.bad) --- tests/generic/629.out 2022-04-29 23:07:23.545501491 +0800 +++ /root/git/xfstests/results//logdev/generic/629.out.bad 2022-08-06 22:26:50.810355920 +0800 @@ -1,4 +1,5 @@ QA output created by 629 +mke2fs 1.46.5 (30-Dec-2021) test o_sync write 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/0 test unaligned copy range o_sync ... (Run 'diff -u /root/git/xfstests/tests/generic/629.out /root/git/xfstests/results//logdev/generic/629.out.bad' to see the entire diff) Ran: generic/250 generic/252 generic/629 Failures: generic/250 generic/252 generic/629 Failed 3 of 3 tests > common/config | 4 + > common/ext4 | 176 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > common/rc | 177 ++------------------------------------------------------- > common/xfs | 23 +++++++ > 4 files changed, 208 insertions(+), 172 deletions(-) > create mode 100644 common/ext4 >