public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Ted Tso <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	Ojaswin Mujoo <ojaswin@linux.ibm.com>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
	Jan Kara <jack@suse.cz>
Subject: [PATCH 0/2] ext4: Fix performance regression with mballoc
Date: Tue, 23 Aug 2022 22:15:52 +0200	[thread overview]
Message-ID: <20220823134508.27854-1-jack@suse.cz> (raw)

Hello,

So I have implemented mballoc improvements to avoid spreading allocations
even with mb_optimize_scan=1. It fixes the performance regression I was able
to reproduce with reaim on my test machine:

                     mb_optimize_scan=0     mb_optimize_scan=1     patched
Hmean     disk-1       2076.12 (   0.00%)     2099.37 (   1.12%)     2032.52 (  -2.10%)
Hmean     disk-41     92481.20 (   0.00%)    83787.47 *  -9.40%*    90308.37 (  -2.35%)
Hmean     disk-81    155073.39 (   0.00%)   135527.05 * -12.60%*   154285.71 (  -0.51%)
Hmean     disk-121   185109.64 (   0.00%)   166284.93 * -10.17%*   185298.62 (   0.10%)
Hmean     disk-161   229890.53 (   0.00%)   207563.39 *  -9.71%*   232883.32 *   1.30%*
Hmean     disk-201   223333.33 (   0.00%)   203235.59 *  -9.00%*   221446.93 (  -0.84%)
Hmean     disk-241   235735.25 (   0.00%)   217705.51 *  -7.65%*   239483.27 *   1.59%*
Hmean     disk-281   266772.15 (   0.00%)   241132.72 *  -9.61%*   263108.62 (  -1.37%)
Hmean     disk-321   265435.50 (   0.00%)   245412.84 *  -7.54%*   267277.27 (   0.69%)

Stefan, can you please test whether these patches fix the problem for you as
well? Comments & review welcome.

								Honza

             reply	other threads:[~2022-08-23 20:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 20:15 Jan Kara [this message]
2022-08-23 20:15 ` [PATCH 1/2] ext4: Make mballoc try target group first even with mb_optimize_scan Jan Kara
2022-08-23 20:15 ` [PATCH 2/2] ext4: Avoid unnecessary spreading of allocations among groups Jan Kara
2022-08-24 10:17 ` [PATCH 0/2] ext4: Fix performance regression with mballoc Stefan Wahren
2022-08-24 10:40   ` Jan Kara
2022-08-24 14:13     ` Jan Kara
2022-08-25 17:49       ` Ojaswin Mujoo
2022-08-26  9:07         ` Jan Kara
2022-08-24 21:24     ` Stefan Wahren
2022-08-25  9:18       ` Jan Kara
2022-08-25 15:48         ` Stefan Wahren
2022-08-26  9:52           ` Jan Kara
2022-08-25 16:57         ` Stefan Wahren
2022-08-26 10:15           ` Jan Kara
2022-08-27 14:36             ` Ojaswin Mujoo
2022-08-29  9:04               ` Jan Kara
2022-08-31  7:36                 ` Ojaswin Mujoo
2022-09-04 10:01               ` Stefan Wahren
2022-09-04 22:32                 ` Andreas Dilger
2022-09-05 10:15                   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220823134508.27854-1-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=harshadshirwadkar@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=regressions@leemhuis.info \
    --cc=stefan.wahren@i2se.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox