From: Zorro Lang <zlang@redhat.com>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: fstests@vger.kernel.org, jack@suse.cz, oliver.sang@intel.com,
lkp@intel.com, linux-ext4@vger.kernel.org, tytso@mit.edu,
lczerner@redhat.com
Subject: Re: [PATCH] ext4/053: Remove nouser_xattr test
Date: Sun, 28 Aug 2022 10:48:58 +0800 [thread overview]
Message-ID: <20220828024858.cf5awn2uksbpchb3@zlang-mailbox> (raw)
In-Reply-To: <1660705823-2172-1-git-send-email-xuyang2018.jy@fujitsu.com>
On Wed, Aug 17, 2022 at 11:10:23AM +0800, Yang Xu wrote:
> Plan to remove noacl and nouser_xattr mount option in kernel because they
> are deprecated[1]. So remove nouser_xattr test in here.
What's the [1]?
We'd better to be careful when we want to remove a testing coverage. I'm not
sure if they've decided to removed this mount option, the ext4/053 is an
important test case for ext4, so I'd like to hear their opinion.
Thanks,
Zorro
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> tests/ext4/053 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/ext4/053 b/tests/ext4/053
> index 555e474e..5d2c478a 100755
> --- a/tests/ext4/053
> +++ b/tests/ext4/053
> @@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do
> mnt oldalloc removed
> mnt orlov removed
> mnt -t user_xattr
> - mnt nouser_xattr
>
> if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then
> mnt -t acl
> --
> 2.27.0
>
next prev parent reply other threads:[~2022-08-28 2:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 3:10 [PATCH] ext4/053: Remove nouser_xattr test Yang Xu
2022-08-28 2:48 ` Zorro Lang [this message]
2022-08-29 1:07 ` xuyang2018.jy
2022-08-29 10:06 ` Jan Kara
2022-08-31 9:31 ` Zorro Lang
2022-08-31 10:37 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220828024858.cf5awn2uksbpchb3@zlang-mailbox \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oliver.sang@intel.com \
--cc=tytso@mit.edu \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox