From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0175ECAAD5 for ; Wed, 31 Aug 2022 10:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbiHaKvb (ORCPT ); Wed, 31 Aug 2022 06:51:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiHaKv3 (ORCPT ); Wed, 31 Aug 2022 06:51:29 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2859D5A3C3; Wed, 31 Aug 2022 03:51:27 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 20E5A2227A; Wed, 31 Aug 2022 10:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661943086; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8KZxa7BkROWFtCJZpT4HFztv+uWtNZCErlyLPEOrTQ4=; b=sqmJ9PM0wpZHkNAS85aj9uz518aQ2XnQtkbTq/O+CTY3nfacrgxywR/5cynYnfgirgp9mH Mc+/x/hRkOKlr1sZDklZX/YrxZjwAFo4p3eMzt36CDeqygI9aLvHxUWUqnT65uRq802lIS 1p6vD3j0ryv2VAaez7Shfs81KmCDhX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661943086; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8KZxa7BkROWFtCJZpT4HFztv+uWtNZCErlyLPEOrTQ4=; b=bHu1UtCzvIt7Rh3BTdHNRRaTnSEFRz0PBvomL6mPmvV1ZkUGR3oA+CEMQxkTi5SFa1noE4 NpUjHxUvdUsUFCBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 09B1413A7C; Wed, 31 Aug 2022 10:51:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2vRKAi49D2OlbQAAMHmgww (envelope-from ); Wed, 31 Aug 2022 10:51:26 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 852B7A067B; Wed, 31 Aug 2022 12:51:25 +0200 (CEST) Date: Wed, 31 Aug 2022 12:51:25 +0200 From: Jan Kara To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, jack@suse.cz, tytso@mit.edu, akpm@linux-foundation.org, axboe@kernel.dk, viro@zeniv.linux.org.uk, rpeterso@redhat.com, agruenba@redhat.com, almaz.alexandrovich@paragon-software.com, mark@fasheh.com, dushistov@mail.ru, hch@infradead.org, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH 03/14] fs/buffer: replace ll_rw_block() Message-ID: <20220831105125.mv2674t37yhns2sf@quack3> References: <20220831072111.3569680-1-yi.zhang@huawei.com> <20220831072111.3569680-4-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831072111.3569680-4-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed 31-08-22 15:21:00, Zhang Yi wrote: > ll_rw_block() is not safe for the sync IO path because it skip buffers > which has been locked by others, it could lead to false positive EIO > when submitting read IO. So stop using ll_rw_block(), switch to use new > helpers which could guarantee buffer locked and submit IO if needed. > > Signed-off-by: Zhang Yi > --- > fs/buffer.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index a663191903ed..e14adc638bfe 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c ... > @@ -1342,7 +1342,8 @@ void __breadahead(struct block_device *bdev, sector_t block, unsigned size) > { > struct buffer_head *bh = __getblk(bdev, block, size); > if (likely(bh)) { > - ll_rw_block(REQ_OP_READ | REQ_RAHEAD, 1, &bh); > + if (trylock_buffer(bh)) > + __bh_read(bh, REQ_RAHEAD, false); I suppose this can be bh_readahead()? > brelse(bh); > } > } Otherwise the patch looks good. Honza -- Jan Kara SUSE Labs, CR