From: Jan Kara <jack@suse.cz>
To: Jason Yan <yanaijie@huawei.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
ritesh.list@gmail.com, lczerner@redhat.com,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 03/13] ext4: factor out ext4_set_def_opts()
Date: Wed, 31 Aug 2022 13:44:45 +0200 [thread overview]
Message-ID: <20220831114445.pmgwqegrr75hw2rm@quack3> (raw)
In-Reply-To: <20220830120411.2371968-4-yanaijie@huawei.com>
On Tue 30-08-22 20:04:01, Jason Yan wrote:
> Factor out ext4_set_def_opts(). No functional change.
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Yeah, nice factorization. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/super.c | 105 ++++++++++++++++++++++++++----------------------
> 1 file changed, 56 insertions(+), 49 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 7341340e3c98..66a128e5a9c8 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4311,6 +4311,61 @@ static struct ext4_sb_info *ext4_alloc_sbi(struct super_block *sb)
> return NULL;
> }
>
> +static void ext4_set_def_opts(struct super_block *sb,
> + struct ext4_super_block *es)
> +{
> + unsigned long def_mount_opts;
> +
> + /* Set defaults before we parse the mount options */
> + def_mount_opts = le32_to_cpu(es->s_default_mount_opts);
> + set_opt(sb, INIT_INODE_TABLE);
> + if (def_mount_opts & EXT4_DEFM_DEBUG)
> + set_opt(sb, DEBUG);
> + if (def_mount_opts & EXT4_DEFM_BSDGROUPS)
> + set_opt(sb, GRPID);
> + if (def_mount_opts & EXT4_DEFM_UID16)
> + set_opt(sb, NO_UID32);
> + /* xattr user namespace & acls are now defaulted on */
> + set_opt(sb, XATTR_USER);
> +#ifdef CONFIG_EXT4_FS_POSIX_ACL
> + set_opt(sb, POSIX_ACL);
> +#endif
> + if (ext4_has_feature_fast_commit(sb))
> + set_opt2(sb, JOURNAL_FAST_COMMIT);
> + /* don't forget to enable journal_csum when metadata_csum is enabled. */
> + if (ext4_has_metadata_csum(sb))
> + set_opt(sb, JOURNAL_CHECKSUM);
> +
> + if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_DATA)
> + set_opt(sb, JOURNAL_DATA);
> + else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_ORDERED)
> + set_opt(sb, ORDERED_DATA);
> + else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_WBACK)
> + set_opt(sb, WRITEBACK_DATA);
> +
> + if (le16_to_cpu(es->s_errors) == EXT4_ERRORS_PANIC)
> + set_opt(sb, ERRORS_PANIC);
> + else if (le16_to_cpu(es->s_errors) == EXT4_ERRORS_CONTINUE)
> + set_opt(sb, ERRORS_CONT);
> + else
> + set_opt(sb, ERRORS_RO);
> + /* block_validity enabled by default; disable with noblock_validity */
> + set_opt(sb, BLOCK_VALIDITY);
> + if (def_mount_opts & EXT4_DEFM_DISCARD)
> + set_opt(sb, DISCARD);
> +
> + if ((def_mount_opts & EXT4_DEFM_NOBARRIER) == 0)
> + set_opt(sb, BARRIER);
> +
> + /*
> + * enable delayed allocation by default
> + * Use -o nodelalloc to turn it off
> + */
> + if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
> + ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
> + set_opt(sb, DELALLOC);
> +}
> +
> static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> {
> struct buffer_head *bh, **group_desc;
> @@ -4320,7 +4375,6 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> ext4_fsblk_t block;
> ext4_fsblk_t logical_sb_block;
> unsigned long offset = 0;
> - unsigned long def_mount_opts;
> struct inode *root;
> int ret = -ENOMEM;
> int blocksize, clustersize;
> @@ -4420,43 +4474,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> sbi->s_csum_seed = ext4_chksum(sbi, ~0, es->s_uuid,
> sizeof(es->s_uuid));
>
> - /* Set defaults before we parse the mount options */
> - def_mount_opts = le32_to_cpu(es->s_default_mount_opts);
> - set_opt(sb, INIT_INODE_TABLE);
> - if (def_mount_opts & EXT4_DEFM_DEBUG)
> - set_opt(sb, DEBUG);
> - if (def_mount_opts & EXT4_DEFM_BSDGROUPS)
> - set_opt(sb, GRPID);
> - if (def_mount_opts & EXT4_DEFM_UID16)
> - set_opt(sb, NO_UID32);
> - /* xattr user namespace & acls are now defaulted on */
> - set_opt(sb, XATTR_USER);
> -#ifdef CONFIG_EXT4_FS_POSIX_ACL
> - set_opt(sb, POSIX_ACL);
> -#endif
> - if (ext4_has_feature_fast_commit(sb))
> - set_opt2(sb, JOURNAL_FAST_COMMIT);
> - /* don't forget to enable journal_csum when metadata_csum is enabled. */
> - if (ext4_has_metadata_csum(sb))
> - set_opt(sb, JOURNAL_CHECKSUM);
> -
> - if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_DATA)
> - set_opt(sb, JOURNAL_DATA);
> - else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_ORDERED)
> - set_opt(sb, ORDERED_DATA);
> - else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_WBACK)
> - set_opt(sb, WRITEBACK_DATA);
> -
> - if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_PANIC)
> - set_opt(sb, ERRORS_PANIC);
> - else if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_CONTINUE)
> - set_opt(sb, ERRORS_CONT);
> - else
> - set_opt(sb, ERRORS_RO);
> - /* block_validity enabled by default; disable with noblock_validity */
> - set_opt(sb, BLOCK_VALIDITY);
> - if (def_mount_opts & EXT4_DEFM_DISCARD)
> - set_opt(sb, DISCARD);
> + ext4_set_def_opts(sb, es);
>
> sbi->s_resuid = make_kuid(&init_user_ns, le16_to_cpu(es->s_def_resuid));
> sbi->s_resgid = make_kgid(&init_user_ns, le16_to_cpu(es->s_def_resgid));
> @@ -4464,17 +4482,6 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> sbi->s_min_batch_time = EXT4_DEF_MIN_BATCH_TIME;
> sbi->s_max_batch_time = EXT4_DEF_MAX_BATCH_TIME;
>
> - if ((def_mount_opts & EXT4_DEFM_NOBARRIER) == 0)
> - set_opt(sb, BARRIER);
> -
> - /*
> - * enable delayed allocation by default
> - * Use -o nodelalloc to turn it off
> - */
> - if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
> - ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
> - set_opt(sb, DELALLOC);
> -
> /*
> * set default s_li_wait_mult for lazyinit, for the case there is
> * no mount option specified.
> --
> 2.31.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-08-31 11:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 12:03 [PATCH 00/13] some refactor of __ext4_fill_super() Jason Yan
2022-08-30 12:03 ` [PATCH 01/13] ext4: goto right label 'failed_mount3a' Jason Yan
2022-08-31 11:36 ` Jan Kara
2022-08-30 12:04 ` [PATCH 02/13] ext4: remove cantfind_ext4 error handler Jason Yan
2022-08-31 11:41 ` Jan Kara
2022-09-01 7:42 ` Jason Yan
2022-08-30 12:04 ` [PATCH 03/13] ext4: factor out ext4_set_def_opts() Jason Yan
2022-08-31 11:44 ` Jan Kara [this message]
2022-08-30 12:04 ` [PATCH 04/13] ext4: factor out ext4_handle_clustersize() Jason Yan
2022-08-31 11:46 ` Jan Kara
2022-08-30 12:04 ` [PATCH 05/13] ext4: factor out ext4_fast_commit_init() Jason Yan
2022-08-31 11:47 ` Jan Kara
2022-08-30 12:04 ` [PATCH 06/13] ext4: factor out ext4_inode_info_init() Jason Yan
2022-08-31 11:49 ` Jan Kara
2022-08-30 12:04 ` [PATCH 07/13] ext4: factor out ext4_encoding_init() Jason Yan
2022-08-31 11:50 ` Jan Kara
2022-08-30 12:04 ` [PATCH 08/13] ext4: factor out ext4_handle_csum() Jason Yan
2022-08-31 11:52 ` Jan Kara
2022-09-01 7:56 ` Jason Yan
2022-08-30 12:04 ` [PATCH 09/13] ext4: factor out ext4_compat_feature_check() Jason Yan
2022-08-31 11:55 ` Jan Kara
2022-09-01 7:58 ` Jason Yan
2022-08-30 12:04 ` [PATCH 10/13] ext4: factor out ext4_geometry_check() Jason Yan
2022-08-31 11:57 ` Jan Kara
2022-08-30 12:04 ` [PATCH 11/13] ext4: factor out ext4_group_desc_init() and ext4_group_desc_free() Jason Yan
2022-08-31 12:00 ` Jan Kara
2022-08-30 12:04 ` [PATCH 12/13] ext4: factor out ext4_load_and_init_journal() Jason Yan
2022-08-31 12:05 ` Jan Kara
2022-08-30 12:04 ` [PATCH 13/13] ext4: factor out ext4_journal_data_check() Jason Yan
2022-08-31 12:06 ` Jan Kara
2022-09-01 7:59 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831114445.pmgwqegrr75hw2rm@quack3 \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox