Re: [PATCH v2 10/18] fsdax: Manage pgmap references at entry insertion and deletion

Jason Gunthorpe
2022-09-23T13:24:32Z

On Thu, Sep 22, 2022 at 02:54:42PM -0700, Dan Williams wrote:

> > I'm thinking broadly about how to make pgmap usable to all the other
> > drivers in a safe and robust way that makes some kind of logical sense.
>
> I think the API should be pgmap_folio_get() because, at least for DAX,
> the memory is already allocated.

I would pick a name that has some logical connection to
ops->page_free()

This function is starting a pairing where once it completes page_free
will eventually be called.

> /**
> * pgmap_get_folio() - reference a folio in a live @pgmap by @pfn
> * @pgmap: live pgmap instance, caller ensures this does not race @pgmap death
> * @pfn: page frame number covered by @pgmap
> */
> struct folio *pgmap_get_folio(struct dev_pagemap *pgmap, unsigned long pfn)
> {
> struct page *page;
>
> VM_WARN_ONCE(pgmap != xa_load(&pgmap_array, PHYS_PFN(phys)));
>
> if (WARN_ONCE(percpu_ref_is_dying(&pgmap->ref)))
> return NULL;

This shouldn't be a WARN?

> page = pfn_to_page(pfn);
> return page_folio(page);
> }

Yeah, makes sense to me, but I would do a len as well to amortize the
cost of all these checks..

> This does not create compound folios, that needs to be coordinated with
> the caller and likely needs an explicit

Does it? What situations do you think the caller needs to coordinate
the folio size? Caller should call the function for each logical unit
of storage it wants to allocate from the pgmap..

Jason