linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-ext4@vger.kernel.org
Cc: linux-fscrypt@vger.kernel.org,
	Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Subject: [PATCH 0/7] ext4 fast-commit fixes
Date: Sun,  6 Nov 2022 14:48:34 -0800	[thread overview]
Message-ID: <20221106224841.279231-1-ebiggers@kernel.org> (raw)

From: Eric Biggers <ebiggers@kernel.org

This series fixes several bugs in the fast-commit feature.

Patch 6 may be the most controversial patch of this series, since it
would make old kernels unable to replay fast-commit journals created by
new kernels.  I'd appreciate any thoughts on whether that's okay.  I can
drop that patch if needed.

I've tested that this series doesn't introduce any regressions with
'gce-xfstests -c ext4/fast_commit -g auto'.  Note that ext4/039,
ext4/053, and generic/475 fail both before and after.

Eric Biggers (7):
  ext4: disable fast-commit of encrypted dir operations
  ext4: don't set up encryption key during jbd2 transaction
  ext4: fix leaking uninitialized memory in fast-commit journal
  ext4: add missing validation of fast-commit record lengths
  ext4: fix unaligned memory access in ext4_fc_reserve_space()
  ext4: fix off-by-one errors in fast-commit block filling
  ext4: simplify fast-commit CRC calculation

 fs/ext4/ext4.h              |   4 +-
 fs/ext4/fast_commit.c       | 203 ++++++++++++++++++------------------
 fs/ext4/fast_commit.h       |   3 +-
 fs/ext4/namei.c             |  44 ++++----
 include/trace/events/ext4.h |   7 +-
 5 files changed, 132 insertions(+), 129 deletions(-)


base-commit: 089d1c31224e6b266ece3ee555a3ea2c9acbe5c2
-- 
2.38.1


             reply	other threads:[~2022-11-06 22:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-06 22:48 Eric Biggers [this message]
2022-11-06 22:48 ` [PATCH 1/7] ext4: disable fast-commit of encrypted dir operations Eric Biggers
2022-11-06 22:48 ` [PATCH 2/7] ext4: don't set up encryption key during jbd2 transaction Eric Biggers
2022-11-06 22:48 ` [PATCH 3/7] ext4: fix leaking uninitialized memory in fast-commit journal Eric Biggers
2022-11-06 22:48 ` [PATCH 4/7] ext4: add missing validation of fast-commit record lengths Eric Biggers
2022-11-06 22:48 ` [PATCH 5/7] ext4: fix unaligned memory access in ext4_fc_reserve_space() Eric Biggers
2022-11-06 22:48 ` [PATCH 6/7] ext4: fix off-by-one errors in fast-commit block filling Eric Biggers
2022-11-06 22:48 ` [PATCH 7/7] ext4: simplify fast-commit CRC calculation Eric Biggers
2022-11-16  1:18 ` [PATCH 0/7] ext4 fast-commit fixes Eric Biggers
2022-11-28 19:03   ` Eric Biggers
2022-12-06 21:04 ` Theodore Ts'o
2022-12-09 16:12   ` harshad shirwadkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221106224841.279231-1-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=harshadshirwadkar@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).