public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: "lihaoxiang (F)" <lihaoxiang9@huawei.com>
Cc: Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org,
	Zhiqiang Liu <liuzhiqiang26@huawei.com>,
	linfeilong@huawei.com, "lijinlin (A)" <lijinlin3@huawei.com>,
	louhongxiang@huawei.com
Subject: Re: [PATCH] quota-nld:remove redundant description after fix setup_sigterm_handler()
Date: Tue, 6 Dec 2022 13:00:23 +0100	[thread overview]
Message-ID: <20221206120023.icw6iqsbtbmn6pnl@quack3> (raw)
In-Reply-To: <3f405e2f-b18a-f12d-7b0e-8cb031df37eb@huawei.com>

On Tue 06-12-22 19:51:26, lihaoxiang (F) wrote:
> In the commit 06b93e5c1caf5d36d51132cb85c11a96cbdae023, it renamed the
> function `use_pid_file` to `setup_sigterm_handler` and excluded to store
> daemon's pid here. So we need to clean the corresponding note in time.

Thanks! I've folded the fixup patch in the previous fix.

								Honza

> ---
>  quota_nld.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/quota_nld.c b/quota_nld.c
> index 82e60c2..58a62af 100644
> --- a/quota_nld.c
> +++ b/quota_nld.c
> @@ -459,7 +459,7 @@ static void remove_pid(int signal)
>  	exit(EXIT_SUCCESS);
>  }
> 
> -/* Store daemon's PID into file and register its removal on SIGTERM */
> +/* Register daemon's PID file removal on SIGTERM */
>  static void setup_sigterm_handler(void)
>  {
>  	struct sigaction term_action;
> -- 
> 2.37.0.windows.1
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2022-12-06 12:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 11:51 [PATCH] quota-nld:remove redundant description after fix setup_sigterm_handler() lihaoxiang (F)
2022-12-06 12:00 ` Jan Kara [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-12-06 11:58 lihaoxiang (F)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221206120023.icw6iqsbtbmn6pnl@quack3 \
    --to=jack@suse.cz \
    --cc=lihaoxiang9@huawei.com \
    --cc=lijinlin3@huawei.com \
    --cc=linfeilong@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=liuzhiqiang26@huawei.com \
    --cc=louhongxiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox