Re: [PATCH v5 7/9] iomap/xfs: Eliminate the iomap_valid handler

Matthew Wilcox
2023-01-04T19:08:25Z

On Wed, Jan 04, 2023 at 09:53:17AM -0800, Darrick J. Wong wrote:
> I wonder if this should be reworked a bit to reduce indenting:
>
> if (PTR_ERR(folio) == -ESTALE) {

FYI this is a bad habit to be in. The compiler can optimise

if (folio == ERR_PTR(-ESTALE))

better than it can optimise the other way around.