* [e2fsprogs PATCH] libsupport: remove unused label in get_devname()
@ 2023-01-04 9:03 Eric Biggers
2023-01-04 10:25 ` Lukas Czerner
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2023-01-04 9:03 UTC (permalink / raw)
To: linux-ext4; +Cc: Lukas Czerner
From: Eric Biggers <ebiggers@google.com>
Address the following compiler warning with gcc -Wall:
devname.c: In function ‘get_devname’:
devname.c:61:1: warning: label ‘out_strdup’ defined but not used [-Wunused-label]
61 | out_strdup:
| ^~~~~~~~~~
Cc: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
lib/support/devname.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/support/devname.c b/lib/support/devname.c
index 8c2349a3..e0306ddf 100644
--- a/lib/support/devname.c
+++ b/lib/support/devname.c
@@ -58,7 +58,6 @@ char *get_devname(blkid_cache cache, const char *token, const char *value)
goto out;
}
-out_strdup:
if (is_file)
ret = strdup(token);
out:
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [e2fsprogs PATCH] libsupport: remove unused label in get_devname()
2023-01-04 9:03 [e2fsprogs PATCH] libsupport: remove unused label in get_devname() Eric Biggers
@ 2023-01-04 10:25 ` Lukas Czerner
0 siblings, 0 replies; 2+ messages in thread
From: Lukas Czerner @ 2023-01-04 10:25 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-ext4
On Wed, Jan 04, 2023 at 01:03:41AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Address the following compiler warning with gcc -Wall:
>
> devname.c: In function ‘get_devname’:
> devname.c:61:1: warning: label ‘out_strdup’ defined but not used [-Wunused-label]
> 61 | out_strdup:
> | ^~~~~~~~~~
Looks good, thanks!
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
>
> Cc: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> lib/support/devname.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/support/devname.c b/lib/support/devname.c
> index 8c2349a3..e0306ddf 100644
> --- a/lib/support/devname.c
> +++ b/lib/support/devname.c
> @@ -58,7 +58,6 @@ char *get_devname(blkid_cache cache, const char *token, const char *value)
> goto out;
> }
>
> -out_strdup:
> if (is_file)
> ret = strdup(token);
> out:
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-04 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-04 9:03 [e2fsprogs PATCH] libsupport: remove unused label in get_devname() Eric Biggers
2023-01-04 10:25 ` Lukas Czerner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox