From: Lukas Czerner <lczerner@redhat.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [e2fsprogs PATCH] libsupport: remove unused label in get_devname()
Date: Wed, 4 Jan 2023 11:25:38 +0100 [thread overview]
Message-ID: <20230104102538.bbttn6is7w6gdsbo@fedora> (raw)
In-Reply-To: <20230104090341.276131-1-ebiggers@kernel.org>
On Wed, Jan 04, 2023 at 01:03:41AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Address the following compiler warning with gcc -Wall:
>
> devname.c: In function ‘get_devname’:
> devname.c:61:1: warning: label ‘out_strdup’ defined but not used [-Wunused-label]
> 61 | out_strdup:
> | ^~~~~~~~~~
Looks good, thanks!
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
>
> Cc: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> lib/support/devname.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/support/devname.c b/lib/support/devname.c
> index 8c2349a3..e0306ddf 100644
> --- a/lib/support/devname.c
> +++ b/lib/support/devname.c
> @@ -58,7 +58,6 @@ char *get_devname(blkid_cache cache, const char *token, const char *value)
> goto out;
> }
>
> -out_strdup:
> if (is_file)
> ret = strdup(token);
> out:
> --
> 2.39.0
>
prev parent reply other threads:[~2023-01-04 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:03 [e2fsprogs PATCH] libsupport: remove unused label in get_devname() Eric Biggers
2023-01-04 10:25 ` Lukas Czerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104102538.bbttn6is7w6gdsbo@fedora \
--to=lczerner@redhat.com \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox