From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: propagate errors from ext2_prepare_chunk
Date: Mon, 16 Jan 2023 17:06:52 +0100 [thread overview]
Message-ID: <20230116160652.GA23301@lst.de> (raw)
In-Reply-To: <20230116111621.rffhrhkdggszwlnu@quack3>
On Mon, Jan 16, 2023 at 12:16:21PM +0100, Jan Kara wrote:
> > - ext2_set_link(new_dir, new_de, new_page, page_addr, old_inode, 1);
> > + err = ext2_set_link(new_dir, new_de, new_page, page_addr,
> > + old_inode, true);
> > + if (err)
> > + goto out_dir;
> > ext2_put_page(new_page, page_addr);
>
> AFAICT we need to call ext2_put_page(new_page, page_addr) also in case of
> error here. I'll fix it up on commit. Thanks for the patch.
Indeed. I was tricked by out_dir doing the cleanup, but that's for
the old entry.
prev parent reply other threads:[~2023-01-16 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 8:52 [PATCH] ext2: propagate errors from ext2_prepare_chunk Christoph Hellwig
2023-01-16 11:16 ` Jan Kara
2023-01-16 16:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116160652.GA23301@lst.de \
--to=hch@lst.de \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox